test(e4): extract PLEX_SUB_URL for round-trip coverage

Move `type Sub` + `PLEX_SUB_URL` out of the 538-line PlexBrowse into a small plexSubUrl.ts so the encode/decode round-trip and its guards can be unit-tested without dragging the component (and its lazy hls.js player) into the test graph. Pure code motion — PlexBrowse imports the two symbols; the `SubviewUrl` import moves with them. Tests lock: encode of each bookmarkable kind, grid/player → null, encode→decode identity, a person name containing ':' round-tripping, and the decode guards (positive-integer playlist id; season needs both ids; non-empty show/info/person arg; unknown kind/garbage → null). 12 tests; full FE gate green (tsc/eslint/prettier/knip).
2026-08-20 05:16:06 +02:00
parent e8a1c252a9
commit 0401dae689
3 changed files with 132 additions and 58 deletions
@@ -0,0 +1,69 @@
+// PLEX_SUB_URL encode/decode round-trip + guards. Extracted from PlexBrowse for this test (E4
+// deep-review deferred gap). Pure — no DOM, no history.
+import { describe, it, expect } from "vitest";
+import { PLEX_SUB_URL as U, type Sub } from "./plexSubUrl";
+
+describe("PLEX_SUB_URL encode", () => {
+  it("mirrors each bookmarkable sub-view to ?v=<kind>:<args>", () => {
+    expect(U.encode({ kind: "show", id: "s1" })).toBe("show:s1");
+    expect(U.encode({ kind: "season", showId: "s1", seasonId: "se2" })).toBe("season:s1:se2");
+    expect(U.encode({ kind: "info", id: "m9" })).toBe("info:m9");
+    expect(U.encode({ kind: "person", name: "Jane Doe" })).toBe("person:Jane Doe");
+    expect(U.encode({ kind: "playlist", id: 12 })).toBe("playlist:12");
+  });
+
+  it("does NOT mirror the root grid or the ephemeral player (encode → null)", () => {
+    expect(U.encode({ kind: "grid" })).toBeNull();
+    expect(U.encode({ kind: "player", id: "m9" })).toBeNull();
+  });
+});
+
+describe("PLEX_SUB_URL round-trip", () => {
+  const cases: Sub[] = [
+    { kind: "show", id: "s1" },
+    { kind: "season", showId: "s1", seasonId: "se2" },
+    { kind: "info", id: "m9" },
+    { kind: "person", name: "Jane Doe" },
+    { kind: "playlist", id: 12 },
+  ];
+  it.each(cases)("encode→decode is identity for %o", (view) => {
+    const raw = U.encode(view);
+    expect(raw).not.toBeNull();
+    expect(U.decode(raw as string)).toEqual(view);
+  });
+
+  it("a person name containing ':' round-trips (tail after the first colon)", () => {
+    const view: Sub = { kind: "person", name: "Dr: Strange: Origins" };
+    expect(U.decode(U.encode(view) as string)).toEqual(view);
+  });
+});
+
+describe("PLEX_SUB_URL decode guards", () => {
+  it("rejects a playlist id that is not a positive integer", () => {
+    expect(U.decode("playlist:")).toBeNull(); // Number("")===0, not >0
+    expect(U.decode("playlist:0")).toBeNull();
+    expect(U.decode("playlist:-1")).toBeNull();
+    expect(U.decode("playlist:1.5")).toBeNull();
+    expect(U.decode("playlist:abc")).toBeNull();
+    expect(U.decode("playlist:12")).toEqual({ kind: "playlist", id: 12 });
+  });
+
+  it("requires both ids for a season", () => {
+    expect(U.decode("season:s1")).toBeNull();
+    expect(U.decode("season:")).toBeNull();
+    expect(U.decode("season:s1:se2")).toEqual({ kind: "season", showId: "s1", seasonId: "se2" });
+  });
+
+  it("requires a non-empty arg for show / info / person", () => {
+    expect(U.decode("show:")).toBeNull();
+    expect(U.decode("info:")).toBeNull();
+    expect(U.decode("person:")).toBeNull();
+  });
+
+  it("rejects an unknown kind or garbage", () => {
+    expect(U.decode("grid")).toBeNull();
+    expect(U.decode("player:m9")).toBeNull(); // player is not URL-restorable
+    expect(U.decode("bogus")).toBeNull();
+    expect(U.decode("")).toBeNull();
+  });
+});