fix(ui): Enter on a selectable title opens it even with its words selected
endsTextSelection takes the click event and exempts a keyboard click (detail 0): Enter / Space ends no selection, so a title selected and then tabbed to opened nothing. All three callers (FocusSafeButton, the Plex caption, the video card title) go through it.
This commit is contained in:
@@ -306,10 +306,10 @@ describe("a Plex card's title stays selectable", () => {
|
||||
range.selectNodeContents(title);
|
||||
window.getSelection()!.removeAllRanges();
|
||||
window.getSelection()!.addRange(range);
|
||||
fireEvent.click(title);
|
||||
fireEvent.click(title, { detail: 1 });
|
||||
expect(onOpen).not.toHaveBeenCalled();
|
||||
window.getSelection()!.removeAllRanges();
|
||||
fireEvent.click(title);
|
||||
fireEvent.click(title, { detail: 1 });
|
||||
expect(onOpen).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user