feat(ui): R3 S3 — surface swallowed errors

- notifyYouTubeActionError: on any non-403 error, show the server's own reason (err.detail, e.g.
  "Not enough quota left today") instead of the caller's generic fallback, which was discarded
  (U-3.2.8). 403 still offers the Connect affordance.
- App boot error now offers a Retry (StateMessage) instead of a dead "Something went wrong" (U-4.2).
- deletePlaylist prefers the server's reason over a blanket "couldn't delete on YouTube" that
  misleads when the failure wasn't the YouTube side.
- Already covered in earlier sprints (verified): the live-search "Load more" already surfaces the
  quota error inline via err.detail, and ChannelPage subscribe/unsubscribe already route through
  notifyYouTubeActionError.
This commit is contained in:
2026-07-22 04:43:02 +02:00
parent b5573b62d1
commit 1c6b7a9a5a
3 changed files with 19 additions and 8 deletions
+5 -2
View File
@@ -31,6 +31,7 @@ import PageShell from "./components/PageShell";
import GlassTuner from "./components/GlassTuner"; import GlassTuner from "./components/GlassTuner";
import ChatDock from "./components/ChatDock"; import ChatDock from "./components/ChatDock";
import Toaster from "./components/Toaster"; import Toaster from "./components/Toaster";
import { StateMessage } from "./components/QueryState";
import ErrorDialog from "./components/ErrorDialog"; import ErrorDialog from "./components/ErrorDialog";
import VersionBanner from "./components/VersionBanner"; import VersionBanner from "./components/VersionBanner";
import DemoBanner from "./components/DemoBanner"; import DemoBanner from "./components/DemoBanner";
@@ -294,8 +295,10 @@ export default function App() {
// network/5xx failure, and no data means "not signed in" → the public landing. // network/5xx failure, and no data means "not signed in" → the public landing.
if (meQuery.error) if (meQuery.error)
return ( return (
<div className="min-h-screen grid place-items-center text-muted"> <div className="min-h-screen grid place-items-center">
{t("common.somethingWrong")} <StateMessage tone="error" onRetry={() => meQuery.refetch()}>
{t("common.somethingWrong")}
</StateMessage>
</div> </div>
); );
if (!meQuery.data) return <Welcome />; if (!meQuery.data) return <Welcome />;
+7 -3
View File
@@ -32,7 +32,7 @@ import {
Upload, Upload,
Youtube, Youtube,
} from "lucide-react"; } from "lucide-react";
import { api, type Video } from "../lib/api"; import { api, HttpError, type Video } from "../lib/api";
import { notify } from "../lib/notifications"; import { notify } from "../lib/notifications";
import { notifyYouTubeActionError } from "../lib/youtubeErrors"; import { notifyYouTubeActionError } from "../lib/youtubeErrors";
import { playlistName } from "../lib/playlistName"; import { playlistName } from "../lib/playlistName";
@@ -489,10 +489,14 @@ export default function Playlists() {
setSelectedId(remaining[0]?.id ?? null); setSelectedId(remaining[0]?.id ?? null);
try { try {
await api.deletePlaylist(deletedId, onYoutube); await api.deletePlaylist(deletedId, onYoutube);
} catch { } catch (err) {
// Prefer the server's specific reason (e.g. a local vs YouTube-side failure) over a blanket
// "couldn't delete on YouTube" that misleads when the failure wasn't the YouTube side.
notify({ notify({
level: "warning", level: "warning",
message: onYoutube ? t("playlists.deleteYtFailed") : t("playlists.deleteFailed"), message:
(err instanceof HttpError && err.detail) ||
(onYoutube ? t("playlists.deleteYtFailed") : t("playlists.deleteFailed")),
}); });
} }
qc.removeQueries({ queryKey: ["playlist", deletedId] }); qc.removeQueries({ queryKey: ["playlist", deletedId] });
+7 -3
View File
@@ -11,7 +11,9 @@ export function notifyYouTubeActionError(
fallbackMessage: string, fallbackMessage: string,
onConnect?: () => void, onConnect?: () => void,
): void { ): void {
if (err instanceof HttpError && err.status === 403) { const httpErr = err instanceof HttpError ? err : null;
if (httpErr?.status === 403) {
// A 403 on a YouTube write action means the write scope isn't granted — offer to connect.
notify({ notify({
level: "error", level: "error",
message: i18n.t("channels.notify.needYouTube"), message: i18n.t("channels.notify.needYouTube"),
@@ -19,7 +21,9 @@ export function notifyYouTubeActionError(
? { label: i18n.t("channels.notify.connect"), onClick: onConnect } ? { label: i18n.t("channels.notify.connect"), onClick: onConnect }
: undefined, : undefined,
}); });
} else { return;
notify({ level: "error", message: fallbackMessage });
} }
// Any other error: prefer the server's own reason (e.g. "Not enough quota left today") over the
// caller's generic fallback — the useful detail was being discarded (U-3.2.8).
notify({ level: "error", message: httpErr?.detail || fallbackMessage });
} }