From 24ad17fc7d24645a1b2fcea634737c2589aa2028 Mon Sep 17 00:00:00 2001
From: npeter83 <npeter83+claude@gmail.com>
Date: Thu, 8 Oct 2026 21:18:48 +0200
Subject: [PATCH] test: hold the show collection's type, an unknown title's 404
 and Brave's fullscreen stand-in

---
 backend/tests/test_plex_client.py                        | 4 ++++
 backend/tests/test_plex_collections_for_item.py          | 6 +++++-
 frontend/src/components/PlayerModal.dom.test.tsx         | 7 +++++++
 frontend/src/components/PlexPlayer.controls.dom.test.tsx | 8 +++++++-
 4 files changed, 23 insertions(+), 2 deletions(-)

diff --git a/backend/tests/test_plex_client.py b/backend/tests/test_plex_client.py
index 76362a4f..1e95db32 100644
--- a/backend/tests/test_plex_client.py
+++ b/backend/tests/test_plex_client.py
@@ -159,6 +159,10 @@ def test_a_collection_is_created_with_a_well_formed_uri(plex):
     assert plex.seen[-1].method == "POST"
     assert params["title"] == "Best of: 90s" and params["sectionId"] == "3"
     assert params["uri"] == "server://abc/com.plexapp.plugins.library/library/metadata/42"
+    assert params["type"] == "1"  # a movie collection unless told otherwise
+    # A show collection is made as one: made as a movie one, it came out empty in a TV section.
+    plex.create_collection("3", "Shows", "42", 2)
+    assert plex.seen[-1].url.params["type"] == "2"
 
     plex.routes["/library/collections"] = {}
     with pytest.raises(PlexError):
diff --git a/backend/tests/test_plex_collections_for_item.py b/backend/tests/test_plex_collections_for_item.py
index c03c78c8..ece1025c 100644
--- a/backend/tests/test_plex_collections_for_item.py
+++ b/backend/tests/test_plex_collections_for_item.py
@@ -78,5 +78,9 @@ def test_a_show_lists_its_own_librarys(db, monkeypatch, override_dep):
     assert [(c["id"], c["contains"]) for c in resp.json()["collections"]] == [("cT", False)]
 
 
-def test_an_episode_or_an_unknown_key_is_not_a_collection_member(db, monkeypatch, override_dep):
+def test_an_episode_is_not_a_collection_member(db, monkeypatch, override_dep):
     assert _get(db, monkeypatch, override_dep, "e1").status_code == 404
+
+
+def test_an_unknown_key_is_not_found(db, monkeypatch, override_dep):
+    assert _get(db, monkeypatch, override_dep, "nope").status_code == 404
diff --git a/frontend/src/components/PlayerModal.dom.test.tsx b/frontend/src/components/PlayerModal.dom.test.tsx
index 5ae0a9b9..e7520c90 100644
--- a/frontend/src/components/PlayerModal.dom.test.tsx
+++ b/frontend/src/components/PlayerModal.dom.test.tsx
@@ -678,6 +678,12 @@ describe("PlayerModal — the docked bar's fullscreen", () => {
         configurable: true,
         value: () => Promise.resolve(),
       });
+    // Brave's stand-in otherwise: a <video>-only requestFullscreen on HTMLElement.prototype.
+    else
+      Object.defineProperty(HTMLElement.prototype, "requestFullscreen", {
+        configurable: true,
+        value: () => true,
+      });
     vi.spyOn(api, "videoDetail").mockReturnValue(new Promise(() => {}));
     const A = vid("A", 0);
     renderModal(
@@ -688,6 +694,7 @@ describe("PlayerModal — the docked bar's fullscreen", () => {
   };
   afterEach(() => {
     delete (Element.prototype as { requestFullscreen?: unknown }).requestFullscreen;
+    delete (HTMLElement.prototype as { requestFullscreen?: unknown }).requestFullscreen;
   });
 
   it("is offered where the browser can fullscreen an element", () => {
diff --git a/frontend/src/components/PlexPlayer.controls.dom.test.tsx b/frontend/src/components/PlexPlayer.controls.dom.test.tsx
index 9a77fa75..88b9ea32 100644
--- a/frontend/src/components/PlexPlayer.controls.dom.test.tsx
+++ b/frontend/src/components/PlexPlayer.controls.dom.test.tsx
@@ -912,12 +912,18 @@ describe("the fullscreen button", () => {
     expect(screen.queryByLabelText("plex.player.fullscreen")).not.toBeNull();
   });
 
-  it("is left out where it cannot, whatever fullscreenEnabled claims", async () => {
+  it("is left out where it cannot, whatever Brave's stand-ins claim", async () => {
     withApi(false);
+    // Brave's: a <video>-only requestFullscreen on HTMLElement.prototype, and fullscreenEnabled true.
+    Object.defineProperty(HTMLElement.prototype, "requestFullscreen", {
+      configurable: true,
+      value: () => true,
+    });
     Object.defineProperty(document, "fullscreenEnabled", { configurable: true, value: true });
     mount({ details: { A: item("A") } });
     await playingAt("/media/A", 100);
     expect(screen.queryByLabelText("plex.player.fullscreen")).toBeNull();
     delete (document as { fullscreenEnabled?: unknown }).fullscreenEnabled;
+    delete (HTMLElement.prototype as { requestFullscreen?: unknown }).requestFullscreen;
   });
 });