fix(design): claim audit part 1b — whole-row switches, the field-family edge, state-layer hovers, icon links, reason-disabled controls, 24/44 targets (E28)
- F12 (owner: A): SwitchRow, the whole settings row toggles; a Config boolean toggles from its title and hint (a label pointed at the switch). - F14 (owner: B): the form dropdown trigger wears the field frame (see-through, the >= 3:1 edge); labelled pills keep the faint edge and the accent-edge hover. DESIGN says so, with log rows. - F6: ~15 bg-card / bg-border / opacity hovers onto the B3 state layer; a lint rule (HOVER_SWAP) refuses the swap, contract-tested. - F10: bare 14px icon links onto IconLink / LinkButton; a local lint rule refuses a glyph-only <a>. - F13: reason-disabled controls are aria-disabled (Users, Channels backfill, Discovery, Scheduler runs, Config tests); FocusSafeButton now swallows the click of a caller's aria-disabled; the Config tests say why while dirty (testDirty, HU/EN). - F5/F11: every control measured live at 24 (mouse) and 44 (coarse) across every page; touch-target is a utility that wins over a caller's min-h-6; link variants carry it too; SegmentedToggle, Tabs, NavRail, menu rows, PriorityStepper, sliders, CheckRow, InnerInput, card links and the rest. - F9: DismissibleChip's label reaches the chip's 24; the Combobox chips are DismissibleChips. - F15: the "+N" / "More..." open state worded as it renders.
This commit is contained in:
@@ -133,13 +133,17 @@ function JobRow({
|
||||
onSave,
|
||||
saving,
|
||||
onRun,
|
||||
runDisabled,
|
||||
paused,
|
||||
runBusy,
|
||||
}: {
|
||||
job: SchedulerJob;
|
||||
onSave: (minutes: number) => void;
|
||||
saving: boolean;
|
||||
onRun: () => void;
|
||||
runDisabled: boolean;
|
||||
/** Unavailable with a reason (the hint says: resume first), so it stays focusable. */
|
||||
paused: boolean;
|
||||
/** A run-all in flight: transient, natively disabled. */
|
||||
runBusy: boolean;
|
||||
}) {
|
||||
const { t } = useTranslation();
|
||||
// The box shows the server's value and holds a draft only while it is being edited, so there is
|
||||
@@ -226,7 +230,7 @@ function JobRow({
|
||||
<Pressable
|
||||
ref={triggerRef}
|
||||
onClick={() => setDraft(String(job.interval_minutes))}
|
||||
className="group text-muted font-normal hover:text-accent inline-flex items-center gap-1 transition"
|
||||
className="group text-muted font-normal hover:text-accent inline-flex min-h-6 items-center gap-1 transition touch-target"
|
||||
>
|
||||
· {t("scheduler.everyMin", { count: job.interval_minutes })}
|
||||
<Pencil className="w-3 h-3 reveal transition" />
|
||||
@@ -260,10 +264,14 @@ function JobRow({
|
||||
"—"
|
||||
)}
|
||||
</div>
|
||||
<Tooltip hint={t("scheduler.runNow")}>
|
||||
<Tooltip
|
||||
hint={paused ? t("scheduler.runAllPausedHint") : t("scheduler.runNow")}
|
||||
always={paused}
|
||||
>
|
||||
<IconButton
|
||||
onClick={onRun}
|
||||
disabled={job.running || runDisabled}
|
||||
aria-disabled={paused}
|
||||
disabled={job.running || runBusy}
|
||||
label={t("scheduler.runNow")}
|
||||
noTitle
|
||||
>
|
||||
@@ -515,13 +523,17 @@ export default function Scheduler() {
|
||||
</div>
|
||||
</div>
|
||||
<div className="flex-1" />
|
||||
<Tooltip hint={data.paused ? t("scheduler.runAllPausedHint") : t("scheduler.runAllHint")}>
|
||||
<Tooltip
|
||||
hint={data.paused ? t("scheduler.runAllPausedHint") : t("scheduler.runAllHint")}
|
||||
always={data.paused}
|
||||
>
|
||||
<Button
|
||||
variant="glass"
|
||||
size="sm"
|
||||
icon={<Play />}
|
||||
onClick={() => runAllMut.mutate()}
|
||||
disabled={runAllMut.isPending || data.paused}
|
||||
aria-disabled={data.paused}
|
||||
disabled={runAllMut.isPending}
|
||||
>
|
||||
{t("scheduler.runAll")}
|
||||
</Button>
|
||||
@@ -579,7 +591,8 @@ export default function Scheduler() {
|
||||
saving={intervalMut.isPending}
|
||||
onSave={(minutes) => intervalMut.mutate({ jobId: job.id, minutes })}
|
||||
onRun={() => runMut.mutate(job.id)}
|
||||
runDisabled={data.paused || runAllMut.isPending}
|
||||
paused={data.paused}
|
||||
runBusy={runAllMut.isPending}
|
||||
/>
|
||||
))}
|
||||
</div>
|
||||
|
||||
Reference in New Issue
Block a user