fix(e12): close what round one broke, and revert two fixes that overreached

Round two of the review loop, on round one's own diff. Two of its findings were
regressions the fixes themselves introduced, which is exactly what the loop is for:

**A per-user refusal was writing onto a shared row.** MediaAssets are deduped across
users, and the generic failure handler puts the message on the asset — right for an
upstream failure, wrong for "your storage is full". Two users queuing the same video share
one asset, so the first user hitting their cap failed the second user's job with the first
one's private reason, telling someone with an empty library to free up space. The refusal
now raises `_OwnerRefused`, caught separately: the job fails, the asset goes back to
`pending` for whoever else holds it. Pinned by a test that drives `_download` directly —
the refusal happens before extraction, so nothing needs stubbing.

**The restore scripts restarted the app, undoing the restore.** `docker compose start`
re-runs the container command, and that runs `alembic upgrade head` — so on the rollback
path this documents as recommended (restore the dump, THEN pin the older tag) the newer
image immediately re-applied the migrations the restore had just undone, and on a FAILED
restore it put the app back on a half-restored schema. Both are the opposite of why the
stop was added. Nothing is restarted automatically now; the scripts say what to run and
when, and the docs' snippets say the same.

**Reverted rather than patched:** the OnboardingWizard toast (the wizard already renders
that failure inline, next to a Retry button — three recoveries for one failure), and
`useVerifyEntry`'s "each new link clears the other". The latter blanked the signed-out
card's only banner, where nothing renders the reset flag to replace it. The two states are
independent again; what changes is that `dismiss` peels ONE layer, which is what the
original finding was actually about.

Also: `Stats` uses the YouTube helper rather than the bare one, so the route's English 403
detail no longer beats the translated fallback under a Hungarian UI; `urlparse` guarded
alongside `.port` (an unclosed bracket raised just as late), the reason renamed `malformed`
since "bad port" misdescribes it; three docstrings narrowed to what the code actually does
(the worker's byte check is per-job, not an aggregate ledger, and not on the edit path;
the redirect residual leaks a reachability oracle, which the note had denied; the
invalidation helper does not cover suspend); the pasted Windows recipe wrapped so `throw`
can stop it; the bash one-liner's failure branch no longer exits 0; and the tests that were
missing for the round-one fixes — the account panel's error paths, the invalidation set,
and the shared-asset case above.

Gate green: vitest 685, pytest 950.
This commit is contained in:
2026-09-05 04:02:57 +02:00
parent fe38dfbcca
commit 358d722ce9
25 changed files with 443 additions and 125 deletions
+55
View File
@@ -0,0 +1,55 @@
// @vitest-environment jsdom
//
// jsdom because the shared module reaches lib/api, which pulls in i18n's localStorage probe.
import { describe, it, expect, vi } from "vitest";
import { QueryClient } from "@tanstack/react-query";
import { invalidateUserAccess, isEmailOff } from "./adminUsers";
import { HttpError } from "./api";
import { qk } from "./queryKeys";
// The set matters, not the call: letting someone in changes three things a user can see at once —
// the row, the pending queue, and the /api/me badge — and the account panel shipped invalidating
// only the first two, so the badge went on claiming the person was stuck until a reload. Pinning the
// keys here is what stops the two call sites drifting apart again, since neither component test
// asserts on invalidation.
describe("invalidateUserAccess", () => {
it("refreshes the row, the pending queue and the badge", () => {
const qc = new QueryClient();
const spy = vi.spyOn(qc, "invalidateQueries").mockImplementation(() => Promise.resolve());
invalidateUserAccess(qc);
const keys = spy.mock.calls.map(([a]) => JSON.stringify(a?.queryKey));
expect(keys).toEqual(
[qk.adminUsers(), qk.adminPendingAccess(), qk.me()].map((k) => JSON.stringify(k)),
);
});
it("also refreshes one account's gate readout when given an id", () => {
const qc = new QueryClient();
const spy = vi.spyOn(qc, "invalidateQueries").mockImplementation(() => Promise.resolve());
invalidateUserAccess(qc, 7);
expect(spy.mock.calls.map(([a]) => JSON.stringify(a?.queryKey))).toContain(
JSON.stringify(qk.adminUserAccess(7)),
);
});
});
// The admin-side resend deliberately reports failures (the public one is silent), so it has to be
// able to say WHICH — a no-SMTP instance is a configuration answer, not a bug.
describe("isEmailOff", () => {
it("recognises the no-mail refusal", () => {
expect(isEmailOff(new HttpError(409, "x", { code: "resend", reason: "email_off" }))).toBe(true);
});
it("is false for any other failure, including a non-HttpError", () => {
expect(isEmailOff(new HttpError(422, "x", { code: "resend", reason: "send_failed" }))).toBe(
false,
);
expect(isEmailOff(new HttpError(500, "x", null))).toBe(false);
expect(isEmailOff(new TypeError("Failed to fetch"))).toBe(false);
expect(isEmailOff(undefined)).toBe(false);
});
});