fix(e12): close what round one broke, and revert two fixes that overreached
Round two of the review loop, on round one's own diff. Two of its findings were regressions the fixes themselves introduced, which is exactly what the loop is for: **A per-user refusal was writing onto a shared row.** MediaAssets are deduped across users, and the generic failure handler puts the message on the asset — right for an upstream failure, wrong for "your storage is full". Two users queuing the same video share one asset, so the first user hitting their cap failed the second user's job with the first one's private reason, telling someone with an empty library to free up space. The refusal now raises `_OwnerRefused`, caught separately: the job fails, the asset goes back to `pending` for whoever else holds it. Pinned by a test that drives `_download` directly — the refusal happens before extraction, so nothing needs stubbing. **The restore scripts restarted the app, undoing the restore.** `docker compose start` re-runs the container command, and that runs `alembic upgrade head` — so on the rollback path this documents as recommended (restore the dump, THEN pin the older tag) the newer image immediately re-applied the migrations the restore had just undone, and on a FAILED restore it put the app back on a half-restored schema. Both are the opposite of why the stop was added. Nothing is restarted automatically now; the scripts say what to run and when, and the docs' snippets say the same. **Reverted rather than patched:** the OnboardingWizard toast (the wizard already renders that failure inline, next to a Retry button — three recoveries for one failure), and `useVerifyEntry`'s "each new link clears the other". The latter blanked the signed-out card's only banner, where nothing renders the reset flag to replace it. The two states are independent again; what changes is that `dismiss` peels ONE layer, which is what the original finding was actually about. Also: `Stats` uses the YouTube helper rather than the bare one, so the route's English 403 detail no longer beats the translated fallback under a Hungarian UI; `urlparse` guarded alongside `.port` (an unclosed bracket raised just as late), the reason renamed `malformed` since "bad port" misdescribes it; three docstrings narrowed to what the code actually does (the worker's byte check is per-job, not an aggregate ledger, and not on the edit path; the redirect residual leaks a reachability oracle, which the note had denied; the invalidation helper does not cover suspend); the pasted Windows recipe wrapped so `throw` can stop it; the bash one-liner's failure branch no longer exits 0; and the tests that were missing for the round-one fixes — the account panel's error paths, the invalidation set, and the shared-asset case above. Gate green: vitest 685, pytest 950.
This commit is contained in:
@@ -59,15 +59,7 @@ export function useVerifyEntry(): VerifyEntry {
|
||||
// Both halves of the mailed pair arrive the same way — pasted into a running tab, which is a
|
||||
// same-document navigation the import-time snapshot never sees. The verify half got this
|
||||
// listener in E9.5 S2; the reset half was left out, so it stayed silent (DX-17).
|
||||
if (hash.get("reset")) {
|
||||
setResetPending(true);
|
||||
// Same rule as a second verify link below: a newly pasted link must not be shadowed by a
|
||||
// banner still standing from the previous one. Without this the reset guidance is
|
||||
// unreachable whenever an unread verify outcome is on screen, and `dismiss` then clears the
|
||||
// pending flag along with the outcome — the DX-17 silence, one state later.
|
||||
setOutcome(null);
|
||||
setEmail(null);
|
||||
}
|
||||
if (hash.get("reset")) setResetPending(true);
|
||||
};
|
||||
// replaceState (how clearEntryUrl strips the fragment) does NOT fire hashchange, so this cannot
|
||||
// feed itself.
|
||||
@@ -82,12 +74,9 @@ export function useVerifyEntry(): VerifyEntry {
|
||||
clearEntryUrl();
|
||||
if (!token || consumed.current.has(token)) return;
|
||||
consumed.current.add(token);
|
||||
// A second link arriving over an unread first outcome must not leave the OLD banner standing —
|
||||
// whichever kind that outcome was. Clearing both keeps the two states mutually exclusive, which
|
||||
// is what lets the single `dismiss` below clear "whatever is showing" without eating the other.
|
||||
// A second link arriving over an unread first outcome must not leave the OLD banner standing.
|
||||
setOutcome(null);
|
||||
setEmail(null);
|
||||
setResetPending(false);
|
||||
api
|
||||
.verifyEmail(token)
|
||||
.then((r) => {
|
||||
@@ -112,9 +101,18 @@ export function useVerifyEntry(): VerifyEntry {
|
||||
outcome,
|
||||
email,
|
||||
resetPending,
|
||||
// Dismiss peels ONE layer. The two states are independent — a reset link can arrive over an
|
||||
// unread confirmation, and a slow /auth/verify can resolve after one did — so clearing both at
|
||||
// once silently discards whichever the user had not read yet. The banner shows the reset
|
||||
// guidance first (it is the one with something to do), and dismissing it reveals the outcome
|
||||
// underneath rather than taking it with it.
|
||||
dismiss: () => {
|
||||
if (resetPending) {
|
||||
setResetPending(false);
|
||||
return;
|
||||
}
|
||||
setOutcome(null);
|
||||
setResetPending(false);
|
||||
setEmail(null);
|
||||
},
|
||||
};
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user