fix(design): the keyboard ring of a flush row stays visible (E28)
A list item's ring sat 2 px outside it. On a table row it ran under the sticky head and past the table's sides; on a Plex playlist show header, flush in its clipping card, it was cut away and the focus was invisible. A table row (by its tag), a log line and the Plex show header and episode rows now ring inside themselves, the show header with its card's corners. The sticky header's fade-below was drawn at rest, over the first row's top 16 px, hiding the ring's top edge: it now fades in with the first 1rem of scroll (a scroll-driven animation; no fade where unsupported).
This commit is contained in:
@@ -0,0 +1,45 @@
|
||||
import { readFileSync } from "node:fs";
|
||||
|
||||
import { expect, it } from "vitest";
|
||||
|
||||
import { navItemAttrs } from "./listNav";
|
||||
|
||||
// The keyboard ring of a list item (`[data-nav-index]`) sits 2 px OUTSIDE the item: a card with a gap
|
||||
// round it has room. A table row, a log line or a row flush in a clipping card has none — the ring ran
|
||||
// under a sticky table head and past the table's sides, and in a Plex playlist show's card it was
|
||||
// clipped away so the focus was invisible (E28, seen live). A `tr` is inset by its tag (a table
|
||||
// hand-built outside DataTable was the one first reported); the others ask for `inset`. jsdom does no
|
||||
// layout, so what is pinned is the attribute and the rule that draws it inside, with every selector the
|
||||
// outside ring uses (a `:has()` one outranks a plain attribute pair).
|
||||
const css = readFileSync(new URL("../index.css", import.meta.url), "utf8");
|
||||
|
||||
it("an inset item carries the marker, a plain one does not", () => {
|
||||
expect(navItemAttrs(3, "x", { inset: true })).toEqual({
|
||||
"data-nav-index": 3,
|
||||
"data-nav-name": "x",
|
||||
"data-nav-inset": "",
|
||||
});
|
||||
expect(navItemAttrs(3)).toEqual({ "data-nav-index": 3 });
|
||||
});
|
||||
|
||||
it("index.css draws an inset item's ring inside, after the outside rule", () => {
|
||||
const outside = css.indexOf("[data-nav-index]:has([data-nav-open]:focus-visible)");
|
||||
const at = css.indexOf(":is(tr, [data-nav-inset])[data-nav-index],");
|
||||
expect(outside, "the outside ring").toBeGreaterThan(0);
|
||||
expect(at, "the inset rule comes later").toBeGreaterThan(outside);
|
||||
const rule = css.slice(at, css.indexOf("}", at));
|
||||
expect(rule).toContain(":is(tr, [data-nav-inset])[data-nav-index]:focus-visible");
|
||||
expect(rule).toContain(
|
||||
":is(tr, [data-nav-inset])[data-nav-index]:has([data-nav-open]:focus-visible)",
|
||||
);
|
||||
expect(rule).toMatch(/outline-offset:\s*-2px/);
|
||||
});
|
||||
|
||||
// The items that sit flush, by their source: a new one of the kind should be added here.
|
||||
const src = (p: string) => readFileSync(new URL(p, import.meta.url), "utf8");
|
||||
it.each([["../components/LogLine.tsx", /navItemAttrs\(navIndex, [^)]*\{ inset: true \}\)/]])(
|
||||
"%s asks for the inside ring",
|
||||
(file, re) => {
|
||||
expect(src(file)).toMatch(re);
|
||||
},
|
||||
);
|
||||
Reference in New Issue
Block a user