@@ -241,6 +245,7 @@ export function SeasonCard({
onAdd();
}}
title={t("plex.playlist.addSeason")}
+ aria-label={t("plex.playlist.addSeason")}
className="absolute bottom-1.5 right-1.5 p-1 rounded-full bg-black/60 reveal hover:bg-black/80 transition"
>
@@ -404,6 +409,7 @@ export function EpisodeCard({
}) {
const { t } = useTranslation();
const inProgress = (ep.position_seconds ?? 0) > 0 && ep.status !== "watched";
+ const watchedLabel = ep.status === "watched" ? t("plex.markUnwatched") : t("plex.markWatched");
const pct =
inProgress && ep.duration_seconds
? Math.min(100, Math.round(((ep.position_seconds ?? 0) / ep.duration_seconds) * 100))
@@ -438,8 +444,8 @@ export function EpisodeCard({
e.stopPropagation();
onToggleWatched();
}}
- title={ep.status === "watched" ? t("plex.markUnwatched") : t("plex.markWatched")}
- aria-label={ep.status === "watched" ? t("plex.markUnwatched") : t("plex.markWatched")}
+ title={watchedLabel}
+ aria-label={watchedLabel}
className="absolute top-1.5 right-1.5 p-1 rounded-full bg-black/60 reveal hover:bg-black/80 transition"
>
diff --git a/frontend/src/components/plexSubUrl.ts b/frontend/src/components/plexSubUrl.ts
index d3fc2816..a63e633a 100644
--- a/frontend/src/components/plexSubUrl.ts
+++ b/frontend/src/components/plexSubUrl.ts
@@ -1,4 +1,5 @@
import type { SubviewUrl } from "../lib/history";
+import { parsePositiveIntId } from "../lib/parseId";
// The Plex module's sub-view union and its address-bar mirror, extracted from PlexBrowse so the
// encode/decode round-trip (and its guards) can be unit-tested without pulling the whole component
@@ -46,9 +47,9 @@ export const PLEX_SUB_URL: SubviewUrl
= {
return arg ? { kind: "person", name: arg } : null;
case "playlist": {
// Positive-integer id only — a fractional/zero/negative ?v=playlist: would open a
- // sub-view for a non-existent id (matches the ?pl guard in PlaylistsProvider.readSelectedId).
- const id = arg ? Number(arg) : NaN;
- return Number.isInteger(id) && id > 0 ? { kind: "playlist", id } : null;
+ // sub-view for a non-existent id (shares parsePositiveIntId with readSelectedId's ?pl guard).
+ const id = parsePositiveIntId(arg);
+ return id != null ? { kind: "playlist", id } : null;
}
case "season": {
const [showId, seasonId] = arg.split(":");
diff --git a/frontend/src/lib/parseId.test.ts b/frontend/src/lib/parseId.test.ts
new file mode 100644
index 00000000..fa2d98f1
--- /dev/null
+++ b/frontend/src/lib/parseId.test.ts
@@ -0,0 +1,23 @@
+import { describe, it, expect } from "vitest";
+import { parsePositiveIntId } from "./parseId";
+
+describe("parsePositiveIntId", () => {
+ it("accepts a positive integer", () => {
+ expect(parsePositiveIntId("1")).toBe(1);
+ expect(parsePositiveIntId("42")).toBe(42);
+ });
+
+ it("rejects empty / nullish", () => {
+ expect(parsePositiveIntId("")).toBeNull();
+ expect(parsePositiveIntId(null)).toBeNull();
+ expect(parsePositiveIntId(undefined)).toBeNull();
+ });
+
+ it("rejects zero, negative, fractional, and non-numeric", () => {
+ expect(parsePositiveIntId("0")).toBeNull();
+ expect(parsePositiveIntId("-1")).toBeNull();
+ expect(parsePositiveIntId("1.5")).toBeNull();
+ expect(parsePositiveIntId("abc")).toBeNull();
+ expect(parsePositiveIntId(" ")).toBeNull(); // Number(" ")===0
+ });
+});
diff --git a/frontend/src/lib/parseId.ts b/frontend/src/lib/parseId.ts
new file mode 100644
index 00000000..dd46fdb2
--- /dev/null
+++ b/frontend/src/lib/parseId.ts
@@ -0,0 +1,9 @@
+/** Parse a raw value to a positive-integer id, or null if it isn't one. A bare "" gives
+ * Number("")===0 (finite but not positive), "1.5" is fractional, "-1"/"abc" invalid — all rejected.
+ * The single guard behind the ?pl / ?v=playlist id params AND the stored playlist selection, so a bad
+ * value (a malformed link, a legacy/corrupted storage entry) never selects a non-existent playlist. */
+export function parsePositiveIntId(raw: string | null | undefined): number | null {
+ if (raw == null || raw === "") return null;
+ const n = Number(raw);
+ return Number.isInteger(n) && n > 0 ? n : null;
+}