chore(comments): drop epic, sprint and review-round ids from the code
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
This commit is contained in:
@@ -15,7 +15,7 @@ import { ChipLabelPending } from "./Skeleton";
|
||||
|
||||
// The universal combobox: a react-select / Overseerr-style "combi input" — selected values are
|
||||
// removable chips that live INSIDE a text field you type into, and a checklist of options opens below.
|
||||
// It is the ONE control for "pick value(s) from a (possibly large, possibly async) vocabulary": the E5
|
||||
// It is the ONE control for "pick value(s) from a (possibly large, possibly async) vocabulary": the
|
||||
// Plex filters (genre / age-rating / studio, multi-select) and the collection picker (single-select,
|
||||
// server-searched) are both instances, and the header search typeahead can move onto it later.
|
||||
//
|
||||
@@ -56,12 +56,12 @@ export interface ComboboxProps {
|
||||
clientFilter?: boolean;
|
||||
loading?: boolean;
|
||||
/** The options failed to load: said in the list instead of "No matches" (an error is not an empty
|
||||
* result — E28 review J1). */
|
||||
* result). */
|
||||
error?: string;
|
||||
/** Loads the options again after `error`: a Retry beside the message, and Enter in the field. A
|
||||
* failed list with no way back but closing the dialog was a dead end. */
|
||||
onRetry?: () => void;
|
||||
/** Takes no pick (e.g. the last one is still being written, J2). Soft, like `FocusSafeButton`: the
|
||||
/** Takes no pick (e.g. the last one is still being written). Soft, like `FocusSafeButton`: the
|
||||
* field keeps the focus (a natively disabled one drops it to <body>), announced as unavailable. */
|
||||
disabled?: boolean;
|
||||
/** Shown when there are no options to list. */
|
||||
@@ -81,7 +81,7 @@ export interface ComboboxProps {
|
||||
/** Remember each value's display label as options flow through, so a selected chip can name itself
|
||||
* even after the option leaves the query-narrowed list (async single-select). State, merged DURING
|
||||
* render: a ref written in an effect was read by the render before it, so a chip could name itself
|
||||
* by its raw value until something else re-rendered (E32). */
|
||||
* by its raw value until something else re-rendered. */
|
||||
function useLabelCache(options: readonly ComboboxOption[]): Record<string, string> {
|
||||
const [labelCache, setLabelCache] = useState<Record<string, string>>({});
|
||||
const newLabels = options.filter(
|
||||
@@ -126,7 +126,7 @@ export default function Combobox({
|
||||
onQueryChange?.(q);
|
||||
};
|
||||
// The input node as STATE, not a ref: the handlers below are handed to getReferenceProps during
|
||||
// render, and a ref inside them made the React Compiler skip the whole component (E32).
|
||||
// render, and a ref inside them made the React Compiler skip the whole component.
|
||||
const [inputEl, setInputEl] = useState<HTMLInputElement | null>(null);
|
||||
const { ref: fadeRef, style: fadeStyle } = useScrollFade();
|
||||
|
||||
@@ -294,7 +294,7 @@ export default function Combobox({
|
||||
>
|
||||
{/* The scroll box owns the height cap AND the scroll-fade mask (ref+style on the same element). */}
|
||||
<div ref={fadeRef} style={fadeStyle} className="max-h-64 overflow-y-auto no-scrollbar">
|
||||
{/* The listbox holds the options alone; the lines about the list sit beside it (F4). */}
|
||||
{/* The listbox holds the options alone; the lines about the list sit beside it. */}
|
||||
<PopoverList>
|
||||
{!showError &&
|
||||
visible.map((o) => {
|
||||
|
||||
Reference in New Issue
Block a user