chore(comments): drop epic, sprint and review-round ids from the code
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
This commit is contained in:
@@ -4,11 +4,11 @@
|
||||
// mount→cleanup→mount is what the code under test reacts to, and the module-level layer stack in
|
||||
// ui/Modal (and the overlay-host registry in ui/Toaster) leaks between tests in one file.
|
||||
//
|
||||
// Round 5 fixed this in Chrome and shipped it with NO test: the second mount found the focus
|
||||
// A fix settled this in Chrome and shipped it with NO test: the second mount found the focus
|
||||
// outside the dialog (its own cleanup had just handed it back to the trigger) and moved it to the
|
||||
// first focusable — taking it off an `autoFocus` field a beat after the browser had put it there.
|
||||
// The command palette opened focused on its ✕ in dev and on its search field in prod, from the same
|
||||
// code. Round 6 measured that deleting the fix left all 1009 tests green, which is why this exists.
|
||||
// code. A check measured that deleting the fix left all 1009 tests green, which is why this exists.
|
||||
//
|
||||
// Same offsetParent stub as Modal.dom.test.tsx: jsdom never lays out, so every element reports
|
||||
// offsetParent null and `focusablesIn` would see nothing.
|
||||
|
||||
Reference in New Issue
Block a user