chore(comments): drop epic, sprint and review-round ids from the code
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
This commit is contained in:
@@ -210,21 +210,15 @@
|
||||
"no-restricted-globals": [
|
||||
0,
|
||||
{
|
||||
"message": "Use the logged request layer: `fetch` belongs to src/lib/http.ts only (E22 S4 — a request outside it never reaches the client log).",
|
||||
"message": "Use the logged request layer: `fetch` belongs to src/lib/http.ts only — a request outside it never reaches the client log.",
|
||||
"name": "fetch"
|
||||
},
|
||||
{
|
||||
"message": "Use the logged request layer: `XMLHttpRequest` belongs to src/lib/api/core.ts only (E22 S4 — a request outside it never reaches the client log).",
|
||||
"message": "Use the logged request layer: `XMLHttpRequest` belongs to src/lib/api/core.ts only — a request outside it never reaches the client log.",
|
||||
"name": "XMLHttpRequest"
|
||||
},
|
||||
{
|
||||
"message": "No `WebSocket` without a logged owner module (E22 S4).",
|
||||
"name": "WebSocket"
|
||||
},
|
||||
{
|
||||
"message": "No `EventSource` without a logged owner module (E22 S4).",
|
||||
"name": "EventSource"
|
||||
}
|
||||
{ "message": "No `WebSocket` without a logged owner module.", "name": "WebSocket" },
|
||||
{ "message": "No `EventSource` without a logged owner module.", "name": "EventSource" }
|
||||
],
|
||||
"no-restricted-imports": [
|
||||
2,
|
||||
@@ -239,18 +233,10 @@
|
||||
],
|
||||
"no-restricted-properties": [
|
||||
0,
|
||||
{ "message": "Use lib/http.ts `send`.", "object": "window", "property": "fetch" },
|
||||
{ "message": "Use lib/http.ts `send`.", "object": "globalThis", "property": "fetch" },
|
||||
{
|
||||
"message": "Use lib/http.ts `send` (E22 S4).",
|
||||
"object": "window",
|
||||
"property": "fetch"
|
||||
},
|
||||
{
|
||||
"message": "Use lib/http.ts `send` (E22 S4).",
|
||||
"object": "globalThis",
|
||||
"property": "fetch"
|
||||
},
|
||||
{
|
||||
"message": "Use lib/api/core.ts `beacon` (E22 S4).",
|
||||
"message": "Use lib/api/core.ts `beacon`.",
|
||||
"object": "navigator",
|
||||
"property": "sendBeacon"
|
||||
}
|
||||
@@ -282,17 +268,11 @@
|
||||
"no-restricted-globals": [
|
||||
2,
|
||||
{
|
||||
"message": "Use the logged request layer: `fetch` belongs to src/lib/http.ts only (E22 S4 — a request outside it never reaches the client log).",
|
||||
"message": "Use the logged request layer: `fetch` belongs to src/lib/http.ts only — a request outside it never reaches the client log.",
|
||||
"name": "fetch"
|
||||
},
|
||||
{
|
||||
"message": "No `WebSocket` without a logged owner module (E22 S4).",
|
||||
"name": "WebSocket"
|
||||
},
|
||||
{
|
||||
"message": "No `EventSource` without a logged owner module (E22 S4).",
|
||||
"name": "EventSource"
|
||||
}
|
||||
{ "message": "No `WebSocket` without a logged owner module.", "name": "WebSocket" },
|
||||
{ "message": "No `EventSource` without a logged owner module.", "name": "EventSource" }
|
||||
],
|
||||
"no-restricted-imports": [
|
||||
2,
|
||||
@@ -330,17 +310,11 @@
|
||||
"no-restricted-globals": [
|
||||
2,
|
||||
{
|
||||
"message": "Use the logged request layer: `XMLHttpRequest` belongs to src/lib/api/core.ts only (E22 S4 — a request outside it never reaches the client log).",
|
||||
"message": "Use the logged request layer: `XMLHttpRequest` belongs to src/lib/api/core.ts only — a request outside it never reaches the client log.",
|
||||
"name": "XMLHttpRequest"
|
||||
},
|
||||
{
|
||||
"message": "No `WebSocket` without a logged owner module (E22 S4).",
|
||||
"name": "WebSocket"
|
||||
},
|
||||
{
|
||||
"message": "No `EventSource` without a logged owner module (E22 S4).",
|
||||
"name": "EventSource"
|
||||
}
|
||||
{ "message": "No `WebSocket` without a logged owner module.", "name": "WebSocket" },
|
||||
{ "message": "No `EventSource` without a logged owner module.", "name": "EventSource" }
|
||||
],
|
||||
"no-restricted-imports": [
|
||||
2,
|
||||
@@ -740,36 +714,22 @@
|
||||
"no-restricted-globals": [
|
||||
2,
|
||||
{
|
||||
"message": "Use the logged request layer: `fetch` belongs to src/lib/http.ts only (E22 S4 — a request outside it never reaches the client log).",
|
||||
"message": "Use the logged request layer: `fetch` belongs to src/lib/http.ts only — a request outside it never reaches the client log.",
|
||||
"name": "fetch"
|
||||
},
|
||||
{
|
||||
"message": "Use the logged request layer: `XMLHttpRequest` belongs to src/lib/api/core.ts only (E22 S4 — a request outside it never reaches the client log).",
|
||||
"message": "Use the logged request layer: `XMLHttpRequest` belongs to src/lib/api/core.ts only — a request outside it never reaches the client log.",
|
||||
"name": "XMLHttpRequest"
|
||||
},
|
||||
{
|
||||
"message": "No `WebSocket` without a logged owner module (E22 S4).",
|
||||
"name": "WebSocket"
|
||||
},
|
||||
{
|
||||
"message": "No `EventSource` without a logged owner module (E22 S4).",
|
||||
"name": "EventSource"
|
||||
}
|
||||
{ "message": "No `WebSocket` without a logged owner module.", "name": "WebSocket" },
|
||||
{ "message": "No `EventSource` without a logged owner module.", "name": "EventSource" }
|
||||
],
|
||||
"no-restricted-properties": [
|
||||
2,
|
||||
{ "message": "Use lib/http.ts `send`.", "object": "window", "property": "fetch" },
|
||||
{ "message": "Use lib/http.ts `send`.", "object": "globalThis", "property": "fetch" },
|
||||
{
|
||||
"message": "Use lib/http.ts `send` (E22 S4).",
|
||||
"object": "window",
|
||||
"property": "fetch"
|
||||
},
|
||||
{
|
||||
"message": "Use lib/http.ts `send` (E22 S4).",
|
||||
"object": "globalThis",
|
||||
"property": "fetch"
|
||||
},
|
||||
{
|
||||
"message": "Use lib/api/core.ts `beacon` (E22 S4).",
|
||||
"message": "Use lib/api/core.ts `beacon`.",
|
||||
"object": "navigator",
|
||||
"property": "sendBeacon"
|
||||
}
|
||||
@@ -797,11 +757,11 @@
|
||||
"selector": "JSXOpeningElement[name.name='select']"
|
||||
},
|
||||
{
|
||||
"message": "px-frozen font size doesn't scale with --font-scale: use text-2xs/text-3xs or text-[Nrem], not text-[Npx] (R10 S2).",
|
||||
"message": "px-frozen font size doesn't scale with --font-scale: use text-2xs/text-3xs or text-[Nrem], not text-[Npx].",
|
||||
"selector": "Literal[value=/text-\\[[\\d.]+px\\]/]"
|
||||
},
|
||||
{
|
||||
"message": "px-frozen font size doesn't scale with --font-scale: use text-2xs/text-3xs or text-[Nrem], not text-[Npx] (R10 S2).",
|
||||
"message": "px-frozen font size doesn't scale with --font-scale: use text-2xs/text-3xs or text-[Nrem], not text-[Npx].",
|
||||
"selector": "TemplateElement[value.raw=/text-\\[[\\d.]+px\\]/]"
|
||||
},
|
||||
{
|
||||
@@ -1019,36 +979,22 @@
|
||||
"no-restricted-globals": [
|
||||
0,
|
||||
{
|
||||
"message": "Use the logged request layer: `fetch` belongs to src/lib/http.ts only (E22 S4 — a request outside it never reaches the client log).",
|
||||
"message": "Use the logged request layer: `fetch` belongs to src/lib/http.ts only — a request outside it never reaches the client log.",
|
||||
"name": "fetch"
|
||||
},
|
||||
{
|
||||
"message": "Use the logged request layer: `XMLHttpRequest` belongs to src/lib/api/core.ts only (E22 S4 — a request outside it never reaches the client log).",
|
||||
"message": "Use the logged request layer: `XMLHttpRequest` belongs to src/lib/api/core.ts only — a request outside it never reaches the client log.",
|
||||
"name": "XMLHttpRequest"
|
||||
},
|
||||
{
|
||||
"message": "No `WebSocket` without a logged owner module (E22 S4).",
|
||||
"name": "WebSocket"
|
||||
},
|
||||
{
|
||||
"message": "No `EventSource` without a logged owner module (E22 S4).",
|
||||
"name": "EventSource"
|
||||
}
|
||||
{ "message": "No `WebSocket` without a logged owner module.", "name": "WebSocket" },
|
||||
{ "message": "No `EventSource` without a logged owner module.", "name": "EventSource" }
|
||||
],
|
||||
"no-restricted-properties": [
|
||||
0,
|
||||
{ "message": "Use lib/http.ts `send`.", "object": "window", "property": "fetch" },
|
||||
{ "message": "Use lib/http.ts `send`.", "object": "globalThis", "property": "fetch" },
|
||||
{
|
||||
"message": "Use lib/http.ts `send` (E22 S4).",
|
||||
"object": "window",
|
||||
"property": "fetch"
|
||||
},
|
||||
{
|
||||
"message": "Use lib/http.ts `send` (E22 S4).",
|
||||
"object": "globalThis",
|
||||
"property": "fetch"
|
||||
},
|
||||
{
|
||||
"message": "Use lib/api/core.ts `beacon` (E22 S4).",
|
||||
"message": "Use lib/api/core.ts `beacon`.",
|
||||
"object": "navigator",
|
||||
"property": "sendBeacon"
|
||||
}
|
||||
@@ -1217,21 +1163,15 @@
|
||||
"no-restricted-globals": [
|
||||
0,
|
||||
{
|
||||
"message": "Use the logged request layer: `fetch` belongs to src/lib/http.ts only (E22 S4 — a request outside it never reaches the client log).",
|
||||
"message": "Use the logged request layer: `fetch` belongs to src/lib/http.ts only — a request outside it never reaches the client log.",
|
||||
"name": "fetch"
|
||||
},
|
||||
{
|
||||
"message": "Use the logged request layer: `XMLHttpRequest` belongs to src/lib/api/core.ts only (E22 S4 — a request outside it never reaches the client log).",
|
||||
"message": "Use the logged request layer: `XMLHttpRequest` belongs to src/lib/api/core.ts only — a request outside it never reaches the client log.",
|
||||
"name": "XMLHttpRequest"
|
||||
},
|
||||
{
|
||||
"message": "No `WebSocket` without a logged owner module (E22 S4).",
|
||||
"name": "WebSocket"
|
||||
},
|
||||
{
|
||||
"message": "No `EventSource` without a logged owner module (E22 S4).",
|
||||
"name": "EventSource"
|
||||
}
|
||||
{ "message": "No `WebSocket` without a logged owner module.", "name": "WebSocket" },
|
||||
{ "message": "No `EventSource` without a logged owner module.", "name": "EventSource" }
|
||||
],
|
||||
"no-restricted-imports": [
|
||||
2,
|
||||
@@ -1254,18 +1194,10 @@
|
||||
],
|
||||
"no-restricted-properties": [
|
||||
0,
|
||||
{ "message": "Use lib/http.ts `send`.", "object": "window", "property": "fetch" },
|
||||
{ "message": "Use lib/http.ts `send`.", "object": "globalThis", "property": "fetch" },
|
||||
{
|
||||
"message": "Use lib/http.ts `send` (E22 S4).",
|
||||
"object": "window",
|
||||
"property": "fetch"
|
||||
},
|
||||
{
|
||||
"message": "Use lib/http.ts `send` (E22 S4).",
|
||||
"object": "globalThis",
|
||||
"property": "fetch"
|
||||
},
|
||||
{
|
||||
"message": "Use lib/api/core.ts `beacon` (E22 S4).",
|
||||
"message": "Use lib/api/core.ts `beacon`.",
|
||||
"object": "navigator",
|
||||
"property": "sendBeacon"
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user