chore(comments): drop epic, sprint and review-round ids from the code
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
This commit is contained in:
@@ -142,7 +142,7 @@ describe("closeOverlaysThenNavigate", () => {
|
||||
// Not inside the popstate dispatch that settled it — a later listener would still apply the
|
||||
// OLD entry's page over the push. Asserted FROM such a later listener (registered after the
|
||||
// helper's own), not after `settle()`: that async act can flush the unmounts on a macrotask,
|
||||
// and the navigate task sometimes ran first — a 1-in-5 false failure (E11 S2b gate).
|
||||
// and the navigate task sometimes ran first — a 1-in-5 false failure in the gate.
|
||||
const navigatedByPopstate: number[] = [];
|
||||
const laterListener = () => navigatedByPopstate.push(navigate.mock.calls.length);
|
||||
window.addEventListener("popstate", laterListener);
|
||||
@@ -165,7 +165,7 @@ describe("closeOverlaysThenNavigate", () => {
|
||||
|
||||
// An overlay's Back callback is a Back STEP: the Plex player keeps its panels on one entry and peels
|
||||
// one per call. Called once, the entry stayed and the navigation was dropped 1.5 s later — `i`, `d`,
|
||||
// Shift+W in the player closed the info panel and nothing else (deep-review E11 round 1).
|
||||
// Shift+W in the player closed the info panel and nothing else.
|
||||
it("asks again, a render apart, when one call peels only a step off the overlay", async () => {
|
||||
const back = stubBack();
|
||||
try {
|
||||
|
||||
Reference in New Issue
Block a user