chore(comments): drop epic, sprint and review-round ids from the code
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
This commit is contained in:
@@ -2,7 +2,7 @@
|
||||
//
|
||||
// useHistorySubview: a module's active sub-view rides in history.state._sub, with optional address-bar
|
||||
// mirroring so a deep sub-view (Plex show/season/info/person/playlist) is bookmarkable. This backfills
|
||||
// the E4 deep-review's deferred coverage for the S2 fix — the seed AND the popstate handler must share
|
||||
// the coverage a review found missing — the seed AND the popstate handler must share
|
||||
// the SAME URL fallback, so a popstate that lands on a bookmark entry (URL-only, no _sub — e.g. after
|
||||
// an overlay's programmatic history.back()) restores the sub-view from the URL instead of collapsing
|
||||
// it to root. The overlay/back-ladder half of history.ts is covered in history.dom.test.ts.
|
||||
@@ -77,7 +77,7 @@ describe("useHistorySubview open", () => {
|
||||
expect(window.location.search).toBe(""); // ?v dropped
|
||||
});
|
||||
|
||||
// E24: a cross-module hand-off (Home plays a Plex title) arrives on an entry the page navigation
|
||||
// A cross-module hand-off (Home plays a Plex title) arrives on an entry the page navigation
|
||||
// just pushed. Opening the sub-view on TOP of it stranded the user on a module root they never
|
||||
// visited — browser-Back from the player landed on the Plex Discover page instead of Home
|
||||
// (measured 2026-09-06). `replace` makes the sub-view BE that entry.
|
||||
@@ -121,7 +121,7 @@ describe("useHistorySubview popstate", () => {
|
||||
expect(result.current.view).toBe("a");
|
||||
});
|
||||
|
||||
it("restores from the ?<key> URL when the landed entry has no _sub — the S2 bookmark fix", () => {
|
||||
it("restores from the ?<key> URL when the landed entry has no _sub — the bookmark fix", () => {
|
||||
// Start in-app at root, then a popstate lands on a URL-only bookmark entry (no _sub). Reading
|
||||
// history.state alone would wrongly collapse to root; the shared URL fallback must decode ?v=b.
|
||||
const { result } = renderHook(() => useHistorySubview("root", url));
|
||||
@@ -139,7 +139,7 @@ describe("useHistorySubview popstate", () => {
|
||||
});
|
||||
});
|
||||
|
||||
// E28 review E1: a one-shot flag the view is OPENED with (the Plex player's `fromStart`, a card's
|
||||
// A one-shot flag the view is OPENED with (the Plex player's `fromStart`, a card's
|
||||
// Restart) rode in history.state._sub, so a reload or a Forward onto that entry restarted from 0
|
||||
// again — and the player's checkpoint then overwrote the resume point. `entry` says what the
|
||||
// history entry keeps of a view; the view itself still opens with the flag.
|
||||
|
||||
Reference in New Issue
Block a user