fix(notifications): a notice keeps what to say and says it in the reader's language when shown

frontend/src/lib/downloads.test.ts

@@ -21,17 +21,21 @@ vi.mock("./api", () => ({
   api: { downloadLinks, createDownloadLink, folderLinks, createFolderLink },
 }));
 vi.mock("./clipboard", () => ({ copyText }));
-vi.mock("./notifications", () => ({ notify }));
+vi.mock("./notifications", async (importOriginal) => ({
+  ...(await importOriginal<typeof import("./notifications")>()),
+  notify,
+}));
 
 import { quickShareLink } from "./downloads";
 import { qk } from "./queryKeys";
+import { msg, type NotifText } from "./notifications";
 
 const t = (k: string) => k;
 const origin = window.location.origin;
 
 type ToastArg = {
   level: string;
-  message: string;
+  message: NotifText;
   action?: { label: string; onClick: () => void };
 };
 const firstToast = () => notify.mock.calls[0]![0] as ToastArg;
@@ -63,7 +67,7 @@ describe("quickShareLink", () => {
     expect(copyText).toHaveBeenCalledWith(`${origin}/watch/tok7`);
     const arg = firstToast();
     expect(arg.level).toBe("success");
-    expect(arg.message).toBe("downloads.share.linkCopied");
+    expect(arg.message).toEqual(msg("downloads.share.linkCopied"));
     expect(arg.action!.label).toBe("downloads.share.openNewTab");
     arg.action!.onClick();
     expect(openSpy).toHaveBeenCalledWith(`${origin}/watch/tok7`, "_blank", "noopener,noreferrer");
@@ -134,7 +138,7 @@ describe("quickShareLink", () => {
     expect(url).toBe(`${origin}/watch/x`); // the link is never a dead end
     const arg = firstToast();
     expect(arg.level).toBe("warning");
-    expect(arg.message).toBe("downloads.share.copyFailed");
+    expect(arg.message).toEqual(msg("downloads.share.copyFailed"));
     expect(arg.action!.label).toBe("downloads.share.openNewTab");
   });
 
@@ -148,7 +152,7 @@ describe("quickShareLink", () => {
     expect(copyText).not.toHaveBeenCalled();
     // Titled with what failed, and carrying why (notifyActionError), not a bare message.
     expect(notify).toHaveBeenCalledWith(
-      expect.objectContaining({ level: "error", title: "downloads.share.linkFailed" }),
+      expect.objectContaining({ level: "error", title: msg("downloads.share.linkFailed") }),
     );
   });
 });