fix(player): first-class maximise/fullscreen view (UAT round)
UAT feedback on the F-maximise view — three fixes: - Own control bar in the big views (maximise + our fullscreen): previous/next + N/M, auto-advance, loop, add-to-playlist, download, mark-watched, exit, and a true-fullscreen toggle. Auto-hides on idle. Add/download are hidden in true fullscreen (their popovers portal to <body>, outside the fullscreen element). - Wheel volume works in the big views again: the centre interaction overlay is now armed in maximise/fullscreen (it only yields to YouTube's own settings menu), so the wheel bubbles to our handler instead of the bare iframe. F also offers true fullscreen that WE own (Fullscreen API on the stage), so wheel/ arrow volume and our controls work inside it too — YouTube's own fullscreen button, which we never surface, is not involved. - Back (mouse/browser) steps out one level at a time via nested history layers (useBackToExit): fullscreen -> maximise -> the modal -> closed, instead of closing the whole player at once. Verified in Chrome: wheel volume in maximise + fullscreen, the control bar, and the full Back ladder (fullscreen -> maximise -> modal -> closed).
This commit is contained in:
@@ -114,3 +114,26 @@ export function useBackToClose(onClose: () => void): void {
|
||||
};
|
||||
}, []);
|
||||
}
|
||||
|
||||
/** A Back-closable layer that exists only WHILE `active`. Stacks on top of `useBackToClose` and any
|
||||
* other active `useBackToExit` (LIFO) so nested views peel off one Back at a time — e.g. a player's
|
||||
* fullscreen sits above its maximise, which sits above the player itself: Back exits fullscreen,
|
||||
* then maximise, then closes the player. Leaving a layer by its own control (button/Esc) flips
|
||||
* `active` false, whose cleanup drops the entry and its history state on the next tick — exactly the
|
||||
* useBackToClose lifecycle, just gated on a flag. `onExit` runs on a genuine Back while active. */
|
||||
export function useBackToExit(active: boolean, onExit: () => void): void {
|
||||
const cb = useRef(onExit);
|
||||
cb.current = onExit;
|
||||
useEffect(() => {
|
||||
if (!active) return;
|
||||
ensureOverlayListener();
|
||||
const entry: Overlay = { token: ++overlayCounter, cb: () => cb.current() };
|
||||
overlayStack.push(entry);
|
||||
scheduleReconcile();
|
||||
return () => {
|
||||
const idx = overlayStack.indexOf(entry);
|
||||
if (idx !== -1) overlayStack.splice(idx, 1);
|
||||
scheduleReconcile();
|
||||
};
|
||||
}, [active]);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user