fix(downloads): an upload's cancel, progress, failure and notice speak of an upload
- Cancelling an upload asks "Delete upload?" and says the uploaded file is
removed from the server with it.
- The phone-safe conversion's real ffmpeg % shows as a bar ("Converting for
phones"), not an indeterminate pulse.
- A failed upload is titled "The upload isn't ready", with its own reasons
(convert_failed, retryable; upload_missing) instead of download copy.
- The inbox says "Upload ready to share" for a converted upload.
This commit is contained in:
@@ -14,7 +14,7 @@ import {
|
||||
relativeTime,
|
||||
} from "../lib/format";
|
||||
import { navItemAttrs } from "../lib/listNav";
|
||||
import { failCopyKeys } from "../lib/downloadFailure";
|
||||
import { failCopyKeys, failTitleKey } from "../lib/downloadFailure";
|
||||
import { displayUrl, hasOwnTitle, jobTitle } from "./downloadTitle";
|
||||
import { IconButton } from "./ui/IconButton";
|
||||
import { Pressable } from "./ui/Pressable";
|
||||
@@ -34,12 +34,14 @@ const STATUS_CLS: Record<string, string> = {
|
||||
};
|
||||
|
||||
// Byte-progress phases (show a % bar) vs ffmpeg post-steps (no %, indeterminate pulse).
|
||||
// "editing" (the phase-2 editor) reports a real % from ffmpeg's out_time, so it gets a bar.
|
||||
const DOWNLOAD_PHASES = ["video", "audio", "editing"];
|
||||
// "editing" (the phase-2 editor) and "converting" (the phone-safe conversion of a download or an
|
||||
// upload) report a real % from ffmpeg's out_time, so they get a bar.
|
||||
const DOWNLOAD_PHASES = ["video", "audio", "editing", "converting"];
|
||||
const PHASE_KEYS = [
|
||||
"video",
|
||||
"audio",
|
||||
"editing",
|
||||
"converting",
|
||||
"merging",
|
||||
"audio_extract",
|
||||
"thumbnail",
|
||||
@@ -313,7 +315,7 @@ export function DownloadRow({
|
||||
<Pressable
|
||||
onClick={() => onShowError?.(job)}
|
||||
className="text-danger inline-block leading-6 min-h-6 touch-target pointer-coarse:leading-(--touch-target)"
|
||||
title={t("downloads.errors.fail.title")}
|
||||
title={t(failTitleKey(job))}
|
||||
>
|
||||
· {t(failCopyKeys(job, "short"))}{" "}
|
||||
<span className="text-muted underline">
|
||||
|
||||
Reference in New Issue
Block a user