chore(gate): shellcheck joins the gate — every tracked shell script, the host binary held to a pin

This commit is contained in:
2026-10-17 15:31:34 +02:00
parent 0a1fef28ac
commit 66181d1394
4 changed files with 37 additions and 3 deletions
+17 -1
View File
@@ -20,6 +20,7 @@
# stops at the first failure hides the second until the first is fixed. The backend lanes run in the
# test image (backend/Dockerfile.test): requirements.lock will not install on Windows (uvloop), and a
# type checker or auditor without the real packages reports nonsense.
# shellcheck disable=SC2329 # the lane functions below are called by name, through lane()
set -u
cd "$(dirname "$0")/.." || exit 2
mode=all
@@ -121,6 +122,20 @@ ruff_pinned() {
ruff_check() { ruff_pinned && python -m ruff check --config backend/ruff.toml backend scripts; }
ruff_format() { ruff_pinned && python -m ruff format --check --config backend/ruff.toml backend scripts; }
# Every tracked shell script (the gate itself, backup/restore, the installer, the image's entrypoint) at
# the linter's full default bar, info included. Host shellcheck, held to this pin like ruff: a newer one
# adds checks, and a gate must not change under a green commit.
SHELLCHECK_PIN=0.11.0
shellcheck_lane() {
local host
host="$(shellcheck --version 2>/dev/null | sed -n 's/^version: //p')"
if [ "$host" != "$SHELLCHECK_PIN" ]; then
echo "shellcheck ${host:-missing} on the host, $SHELLCHECK_PIN pinned — https://github.com/koalaman/shellcheck/releases" >&2
return 1
fi
git ls-files -z -- '*.sh' | xargs -0 shellcheck
}
# New errors only: the pre-existing ones are in backend/.basedpyright/baseline.json. basedpyright
# TIGHTENS that file by itself when errors go, and the tree is bind-mounted read-write, so a green run
# can leave it rewritten: that fails here until it is committed, or the next run's stack reads stale.
@@ -143,6 +158,7 @@ frontend() { (cd frontend && "$@"); }
gate_t0="$(ms)"
lane "ruff" ruff_check
lane "ruff format --check" ruff_format
lane "shellcheck (every shell script)" shellcheck_lane
lane "basedpyright (new errors only)" basedpyright
# every frontend lane judges the HOST node_modules: this proves it is the tree the lock pins
lane "lock check (frontend/node_modules == package-lock.json)" node scripts/check-node-modules.mjs
@@ -158,7 +174,7 @@ pytest_lane() { # the full suite against a throwaway Postgres; --pull keeps the
local rc=0
docker compose -f "$TESTCOMPOSE" up --build --abort-on-container-exit --exit-code-from test || rc=1
docker compose -f "$TESTCOMPOSE" down -v >/dev/null 2>&1
return $rc
return "$rc"
}
# Every pinned backend package against the advisory databases, at any severity — the lock is a full
# `pip freeze`, so it is audited as written, without a resolver. An advisory with no fix is answered