fix(downloads): GIF review round 1 — shape, HDR, caps, audio, copy
- A GIF squares its pixels before the size, so an anamorphic source keeps
its shown shape (a 720x480 DVD at 16:9 was 480x320).
- An editor GIF of an HDR upload is tonemapped, as a clip GIF is.
- The length caps are judged in whole milliseconds: a range exactly at a
cap is no longer refused for a float hair over it.
- A GIF is made of a video only: an audio file is refused with its reason
and the editor offers no GIF for it.
- A GIF clip keeps no audio track: the track neither splits its cache key
nor fails it.
- The editor's GIF notes keep their live region mounted; one size reads
as one ("about 1 MB"), none is shown with nothing kept; the size choices
show their unit; a shared picture that fails to load says so.
- Copy: the two-sentence GIF notes keep their last stop (a copy-rule test
now holds it); the English warns of "only a still picture".
This commit is contained in:
@@ -110,7 +110,10 @@ def normalize(
|
||||
if not (math.isfinite(start_s) and math.isfinite(end_s)) or start_s < 0:
|
||||
raise ClipError("bad_range")
|
||||
start, end = round(start_s, 3), round(end_s, 3)
|
||||
if end - start < MIN_CLIP_S:
|
||||
# Judged in whole milliseconds, as the ends are kept: a float difference lands a hair off
|
||||
# (60.529 - 30.529 = 30.000000000000004), which would refuse a range exactly at a cap.
|
||||
span_ms = round((end - start) * 1000)
|
||||
if span_ms < MIN_CLIP_S * 1000:
|
||||
raise ClipError("too_short")
|
||||
side = None
|
||||
if gif_side is not None:
|
||||
@@ -118,15 +121,16 @@ def normalize(
|
||||
side = gifmod.normalize_side(gif_side)
|
||||
except ValueError as e:
|
||||
raise ClipError("bad_gif") from e
|
||||
if side is not None and end - start > gifmod.MAX_S:
|
||||
if side is not None and gifmod.too_long(start, end):
|
||||
# Its own reason: a GIF's cap is said in seconds, a clip's in minutes.
|
||||
raise ClipError("gif_too_long", limit_s=gifmod.MAX_S)
|
||||
if end - start > MAX_CLIP_S:
|
||||
if span_ms > MAX_CLIP_S * 1000:
|
||||
raise ClipError("too_long", limit_s=MAX_CLIP_S)
|
||||
spec: dict = {"source": source, "ref": ref, "start_s": start, "end_s": end}
|
||||
if side is not None:
|
||||
spec["gif"] = {"side": side}
|
||||
if source == "plex" and audio_track is not None:
|
||||
# A GIF has no sound: the track the player was on is not part of what it is (its cache key).
|
||||
if source == "plex" and audio_track is not None and side is None:
|
||||
if not 0 <= audio_track <= _MAX_AUDIO_TRACK:
|
||||
raise ClipError("bad_audio")
|
||||
spec["audio_track"] = audio_track
|
||||
|
||||
Reference in New Issue
Block a user