fix(downloads): GIF review round 1 — shape, HDR, caps, audio, copy
- A GIF squares its pixels before the size, so an anamorphic source keeps
its shown shape (a 720x480 DVD at 16:9 was 480x320).
- An editor GIF of an HDR upload is tonemapped, as a clip GIF is.
- The length caps are judged in whole milliseconds: a range exactly at a
cap is no longer refused for a float hair over it.
- A GIF is made of a video only: an audio file is refused with its reason
and the editor offers no GIF for it.
- A GIF clip keeps no audio track: the track neither splits its cache key
nor fails it.
- The editor's GIF notes keep their live region mounted; one size reads
as one ("about 1 MB"), none is shown with nothing kept; the size choices
show their unit; a shared picture that fails to load says so.
- Copy: the two-sentence GIF notes keep their last stop (a copy-rule test
now holds it); the English warns of "only a still picture".
This commit is contained in:
@@ -33,6 +33,21 @@ describe("estimateGif", () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe("gifEstimateText", () => {
|
||||
it("says whether both ends read the same, so a panel says one size", () => {
|
||||
expect(gifEstimateText(estimateGif(1, 480, 16 / 9), "en")).toEqual({
|
||||
lo: "1",
|
||||
hi: "1",
|
||||
single: true,
|
||||
});
|
||||
expect(gifEstimateText(estimateGif(10, 480, 16 / 9), "en")).toEqual({
|
||||
lo: "4",
|
||||
hi: "10",
|
||||
single: false,
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe("gifVerdict", () => {
|
||||
it("refuses past the length cap, whatever the size", () => {
|
||||
expect(gifVerdict(30.2, { hi: 1 })).toBe("too_long");
|
||||
|
||||
Reference in New Issue
Block a user