fix(downloads): GIF review round 1 — shape, HDR, caps, audio, copy
- A GIF squares its pixels before the size, so an anamorphic source keeps
its shown shape (a 720x480 DVD at 16:9 was 480x320).
- An editor GIF of an HDR upload is tonemapped, as a clip GIF is.
- The length caps are judged in whole milliseconds: a range exactly at a
cap is no longer refused for a float hair over it.
- A GIF is made of a video only: an audio file is refused with its reason
and the editor offers no GIF for it.
- A GIF clip keeps no audio track: the track neither splits its cache key
nor fails it.
- The editor's GIF notes keep their live region mounted; one size reads
as one ("about 1 MB"), none is shown with nothing kept; the size choices
show their unit; a shared picture that fails to load says so.
- Copy: the two-sentence GIF notes keep their last stop (a copy-rule test
now holds it); the English warns of "only a still picture".
This commit is contained in:
@@ -184,6 +184,22 @@ describe("WatchPage media element", () => {
|
||||
expect(page.getByText(/drag the downloaded file in/)).toBeTruthy();
|
||||
});
|
||||
|
||||
it("a picture that does not load says so, rather than looking like a file without one", async () => {
|
||||
window.history.replaceState({}, "", "/watch/tok-gif-gone");
|
||||
mockMeta({
|
||||
needs_password: false,
|
||||
media_kind: "file",
|
||||
preview: "image",
|
||||
title: "Gone",
|
||||
container: "gif",
|
||||
allow_download: true,
|
||||
file_url: "/gone.gif",
|
||||
});
|
||||
const page = render(<WatchPage />);
|
||||
fireEvent.error(await page.findByRole("img", { name: "Gone" }));
|
||||
expect((await page.findByRole("status")).textContent).toBe("Couldn't load the picture.");
|
||||
});
|
||||
|
||||
it("a view-only picture link shows the picture, without Download or the chat tip", async () => {
|
||||
window.history.replaceState({}, "", "/watch/tok-gif-view");
|
||||
mockMeta({
|
||||
|
||||
Reference in New Issue
Block a user