fix(ui): the reader's own use of a stand-in stops the restore; the pill's name carries its cap
Round 2 of the deep review: - A click on, or a key typed into, the focus keeper's stand-in fires no focusin, so a restore still polling for its list could take the focus from under the reader. A pointerdown or keydown now makes it the reader's own focus. - The Jump-to pill hid its "Ctrl K" from its name (the voice command "click Ctrl K" still matched nothing); the key cap's tooltip now equals its name, so it is not read twice as a description. - listNav's comment still cited DataTable's two layouts as the reason for its visibility filter.
This commit is contained in:
@@ -61,4 +61,26 @@ describe("Back from a sub-view whose held control the swap removed", () => {
|
||||
document.activeElement?.closest("[data-nav-index]")?.getAttribute("data-nav-index"),
|
||||
).toBe("2");
|
||||
});
|
||||
|
||||
it("leaves the focus alone once the reader has used the stand-in", async () => {
|
||||
render(<Page />);
|
||||
button("c").focus();
|
||||
const pos = navPosition()!;
|
||||
act(() => show("detail"));
|
||||
button("Back to library").focus();
|
||||
|
||||
act(() => show("grid"));
|
||||
await act(() => Promise.resolve()); // the keeper places its stand-in
|
||||
const standIn = document.activeElement;
|
||||
expect(standIn?.textContent).toBe("a");
|
||||
// A key typed into it fires no focusin — but it is the reader's focus now.
|
||||
act(() => {
|
||||
standIn!.dispatchEvent(new KeyboardEvent("keydown", { key: "x", bubbles: true }));
|
||||
});
|
||||
const cancel = restoreNavPosition(pos);
|
||||
await wait(120);
|
||||
cancel();
|
||||
|
||||
expect(document.activeElement).toBe(standIn);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user