fix(views): apply the starred default view on first resolve, for feed AND plex (S2)

The feed applied its starred default via a localStorage mirror
(LS.defaultViewFilters) written by SavedViewsProvider and read by
FeedFiltersProvider on load. That raced the login effect: on a genuinely
fresh browser (no LS.filters and no mirror yet) the feed could seed
DEFAULT_FILTERS and never re-apply the default until a reload. Plex had no
default-application at all.

Replace the mirror with a single path: SavedViewsProvider applies the
starred default via cfg.setFilters on the views query's FIRST resolve, but
only into a genuinely fresh module (no stored filters for the account, and
— feed only — no URL filter override). Applying persists it, so it happens
once and the last-view-wins path takes over, matching the documented
storage semantics. Because it runs off cfg.setFilters it delivers the Plex
port for free. Extract pickDefaultToSeed (pure, unit-tested) and cover the
first-resolve/stored/no-default cases for both modules in a provider test.

Removes the now-dead LS.defaultViewFilters key and its mirror read.
This commit is contained in:
2026-08-23 23:05:24 +02:00
parent 5051809940
commit 9538fb1b7a
7 changed files with 230 additions and 48 deletions
+22 -1
View File
@@ -1,5 +1,5 @@
import { describe, it, expect } from "vitest";
import { preferSticky } from "./savedViews";
import { pickDefaultToSeed, preferSticky } from "./savedViews";
const v = (id: number) => ({ id, name: `v${id}` });
@@ -24,3 +24,24 @@ describe("preferSticky", () => {
expect(preferSticky([v(1), v(2)], null)?.id).toBe(1);
});
});
describe("pickDefaultToSeed", () => {
const dv = (id: number, is_default = false) => ({ id, name: `v${id}`, is_default });
it("returns the starred default when the module is a fresh start", () => {
expect(pickDefaultToSeed([dv(1), dv(2, true)], true)?.id).toBe(2);
});
it("returns null when the module already has stored filters / a URL override (canSeed=false)", () => {
expect(pickDefaultToSeed([dv(1), dv(2, true)], false)).toBeNull();
});
it("returns null when there is no starred default, even on a fresh start", () => {
expect(pickDefaultToSeed([dv(1), dv(2)], true)).toBeNull();
expect(pickDefaultToSeed([], true)).toBeNull();
});
it("picks the first default deterministically if several are somehow flagged", () => {
expect(pickDefaultToSeed([dv(1, true), dv(2, true)], true)?.id).toBe(1);
});
});
+15
View File
@@ -10,3 +10,18 @@ export function preferSticky<T extends { id: number }>(
): T | null {
return matches.find((v) => v.id === stickyId) ?? matches[0] ?? null;
}
/** The starred default view to seed a module's filters with on first load, or null to leave them.
* Seeds ONLY when the module is a genuinely fresh start (`canSeed`: no stored filters for this
* account and — feed only — no URL filter override); otherwise the last-session/URL/manual filters
* win, exactly as they do after any edit. First `is_default` wins if somehow several are flagged, so
* the choice is deterministic. This is the single default-application path for BOTH the feed and Plex
* (SavedViewsProvider drives it on the views query's first resolve) — it replaced the feed-only
* localStorage mirror that raced the login effect and left Plex with no default at all. */
export function pickDefaultToSeed<T extends { is_default: boolean }>(
views: T[],
canSeed: boolean,
): T | null {
if (!canSeed) return null;
return views.find((v) => v.is_default) ?? null;
}
-3
View File
@@ -14,9 +14,6 @@ export const LS = {
hints: "siftlode.hints",
lang: "siftlode.lang",
filters: "siftlode.filters",
// Mirror of the default saved view's filters, so it can be applied synchronously on load
// (before the async saved-views query resolves). Kept in sync by SavedViewsWidget.
defaultViewFilters: "siftlode.defaultViewFilters",
page: "siftlode.page",
perfMode: "siftlode.perfMode",
// The feed's view mode (see lib/feedView.ts) — a cache of the server pref, so a reload of an