{t("scheduler.maintenance.batchNote", {
- default: m.revalidate_batch_default.toLocaleString(),
+ default: formatNumber(m.revalidate_batch_default),
})}
@@ -540,31 +540,31 @@ export default function Scheduler() {
icon={Database}
label={t("scheduler.queue.recentPending")}
hint={t("scheduler.queue.recentPendingHint")}
- value={data.queue.channels_recent_pending.toLocaleString()}
+ value={formatNumber(data.queue.channels_recent_pending)}
/>
{t("stats.dailyTotal", {
count: data.range_days,
- units: grandTotal.toLocaleString(),
+ units: formatNumber(grandTotal),
})}
{data.daily.length === 0 ? (
@@ -285,7 +285,7 @@ function SystemStats() {
- {row.total.toLocaleString()}
+ {formatNumber(row.total)}
{/* Proportion bar */}
@@ -343,7 +343,7 @@ function UserRow({ row, max }: { row: AdminQuotaRow; max: number }) {
{actions.map(([action, units]) => (
{quotaActionLabel(action)}
- {units.toLocaleString()}
+ {formatNumber(units)}
))}
diff --git a/frontend/src/components/VideoCard.tsx b/frontend/src/components/VideoCard.tsx
index b24f3d89..12bd40b2 100644
--- a/frontend/src/components/VideoCard.tsx
+++ b/frontend/src/components/VideoCard.tsx
@@ -22,7 +22,7 @@ import { navItemAttrs } from "../lib/listNav";
import clsx from "clsx";
import type { Video, VideoStatus } from "../lib/api";
import { FEED_VIEW_SPEC, type FeedView } from "../lib/feedView";
-import { formatDate, formatDuration, formatViews, relativeTime } from "../lib/format";
+import { formatDate, formatDuration, formatNumber, formatViews, relativeTime } from "../lib/format";
import { isPlainLeftClick } from "../lib/nav";
import ChannelNameLink from "./ChannelNameLink";
@@ -423,7 +423,7 @@ function VideoCard({
// on every line and the tooltip carries the figure regardless.
const viewsCell = (withWord: boolean) =>
video.view_count != null && (
-
+
{formatViews(video.view_count)}
{withWord && ` ${t("card.views")}`}
diff --git a/frontend/src/components/channelColumns.tsx b/frontend/src/components/channelColumns.tsx
index b8b831db..f8b3b0dc 100644
--- a/frontend/src/components/channelColumns.tsx
+++ b/frontend/src/components/channelColumns.tsx
@@ -3,7 +3,7 @@ import type { TFunction } from "i18next";
import { useTranslation } from "react-i18next";
import { Check, Eye, EyeOff, History, UserMinus } from "lucide-react";
import { NO_TAG_SENTINEL, type ManagedChannel } from "../lib/api";
-import { formatCountOrDash, formatTotalHours, relativeTime } from "../lib/format";
+import { formatCountOrDash, formatNumber, formatTotalHours, relativeTime } from "../lib/format";
import type { Column } from "./ui/DataTable";
import Tooltip from "./ui/Tooltip";
import { PriorityStepper } from "./ui/PriorityStepper";
@@ -66,7 +66,7 @@ function StoredCell({ c }: { c: ManagedChannel }) {
/>
)}
- {c.stored_videos.toLocaleString()}
+ {formatNumber(c.stored_videos)}
);
}
diff --git a/frontend/src/components/ui/ItemCount.dom.test.tsx b/frontend/src/components/ui/ItemCount.dom.test.tsx
index 5295edb4..8fd0c962 100644
--- a/frontend/src/components/ui/ItemCount.dom.test.tsx
+++ b/frontend/src/components/ui/ItemCount.dom.test.tsx
@@ -8,11 +8,15 @@ import { render, screen, cleanup } from "@testing-library/react";
import "../../i18n"; // side-effect: initialise the shared i18next instance
import i18n from "i18next";
import ItemCount from "./ItemCount";
+import { formatNumber } from "../../lib/format";
beforeAll(async () => {
await i18n.changeLanguage("en");
});
-afterEach(cleanup);
+afterEach(async () => {
+ cleanup();
+ await i18n.changeLanguage("en"); // a case that switches language must not leak it to the next
+});
const text = () => screen.getByTestId("item-count").textContent;
@@ -24,17 +28,31 @@ describe("ItemCount", () => {
it("pluralises and thousands-separates a normal count", () => {
render(
);
- // Separators come from toLocaleString (runtime-locale dependent) — compare against it, not a fixed
- // en-US string, so the test asserts ItemCount's formatting path rather than the CI locale.
- expect(text()).toBe(`${(192045).toLocaleString()} items`);
+ // Separators come from the shared formatNumber — compare against it, not a fixed en-US string,
+ // so the test asserts ItemCount's formatting path rather than the CI locale.
+ expect(text()).toBe(`${formatNumber(192045)} items`);
+ });
+
+ // The pill used `count.toLocaleString()`, which groups in the BROWSER's locale: a Hungarian UI on
+ // an English browser showed "192,045" instead of "192 045". The title carries the pure number (no
+ // plural string), and both languages are asserted — comparing against the runtime's own default
+ // would pass under the old bug on a machine whose locale happens to match the UI language.
+ it("groups in the UI language, not the browser's", async () => {
+ const title = () => screen.getByTestId("item-count").getAttribute("title");
+ render(
);
+ const asEnglish = title();
+ cleanup();
+ await i18n.changeLanguage("hu");
+ render(
);
+ expect(asEnglish).toBe(new Intl.NumberFormat("en").format(192045));
+ expect(title()).toBe(new Intl.NumberFormat("hu").format(192045));
+ expect(title()).not.toBe(asEnglish);
});
it("collapses a count of a million or more to 1M+, with the exact figure in the tooltip", () => {
render(
);
expect(text()).toBe("1M+ items"); // the "1M+" collapse is locale-independent
- expect(screen.getByTestId("item-count").getAttribute("title")).toBe(
- (1_000_000).toLocaleString(),
- );
+ expect(screen.getByTestId("item-count").getAttribute("title")).toBe(formatNumber(1_000_000));
});
it("shows the icon-only fixed box (empty label) while the count is undefined", () => {
diff --git a/frontend/src/components/ui/ItemCount.tsx b/frontend/src/components/ui/ItemCount.tsx
index 58f07710..f185ce5d 100644
--- a/frontend/src/components/ui/ItemCount.tsx
+++ b/frontend/src/components/ui/ItemCount.tsx
@@ -1,5 +1,6 @@
import { useTranslation } from "react-i18next";
import { Layers } from "lucide-react";
+import { formatNumber } from "../../lib/format";
// At a million and above we stop printing the exact figure — six digits is the readable ceiling, so
// the pill shows "1M+" and the tooltip carries the precise number.
@@ -20,12 +21,12 @@ export default function ItemCount({ count }: { count?: number }) {
? ""
: t("common.itemCount", {
count,
- formattedCount: count >= OVERFLOW_AT ? "1M+" : count.toLocaleString(),
+ formattedCount: count >= OVERFLOW_AT ? "1M+" : formatNumber(count),
});
return (
diff --git a/frontend/src/lib/format.test.ts b/frontend/src/lib/format.test.ts
index e9d8dcb4..ab28ce42 100644
--- a/frontend/src/lib/format.test.ts
+++ b/frontend/src/lib/format.test.ts
@@ -1,5 +1,12 @@
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
-import { RELATIVE_UNITS, formatRuntime, relativeTime, relativeFromMs } from "./format";
+import {
+ RELATIVE_UNITS,
+ formatNumber,
+ formatRuntime,
+ formatTotalHours,
+ relativeTime,
+ relativeFromMs,
+} from "./format";
import en from "../i18n/locales/en/time.json";
import hu from "../i18n/locales/hu/time.json";
@@ -114,6 +121,48 @@ describe("relativeFromMs", () => {
// implementation: 45s floored to "0m", so a playlist of Shorts reported no runtime while the rail
// beside it read "0:45". The table pins every tier boundary, so the sub-minute branch cannot be
// dropped again as "dead code" — it is the one branch a whole-playlist figure reaches.
+// A bare `n.toLocaleString()` groups in the BROWSER's locale, so an English UI in a Hungarian browser
+// printed "1 234 567" (and a Hungarian UI in an English browser "1,234,567"). The case below asserts
+// BOTH languages and that the two differ, rather than comparing against the runtime's own default:
+// the default is whatever locale the machine running the suite has (Hungarian on the dev box, English
+// on a CI image), so a one-language assertion passes under the old bug on half the machines.
+describe("formatNumber", () => {
+ afterEach(() => {
+ i18nStub.language = "en";
+ });
+
+ it("groups in the UI language, not in the runtime's", () => {
+ const asEnglish = formatNumber(1234567);
+ i18nStub.language = "hu";
+ const asHungarian = formatNumber(1234567);
+ expect(asEnglish).toBe(new Intl.NumberFormat("en").format(1234567));
+ expect(asHungarian).toBe(new Intl.NumberFormat("hu").format(1234567));
+ // The load-bearing half: under `toLocaleString()` both come out in the runtime's one locale.
+ expect(asEnglish).not.toBe(asHungarian);
+ });
+
+ it("follows a language switch at runtime (the per-language cache is keyed, not frozen)", () => {
+ expect(formatNumber(1000)).toBe(new Intl.NumberFormat("en").format(1000));
+ i18nStub.language = "hu";
+ expect(formatNumber(1000)).toBe(new Intl.NumberFormat("hu").format(1000));
+ i18nStub.language = "en";
+ expect(formatNumber(1000)).toBe(new Intl.NumberFormat("en").format(1000));
+ });
+
+ it("renders nothing for a value it cannot read, so a caller's dash fallback covers it", () => {
+ expect(formatNumber(null)).toBe("");
+ expect(formatNumber(undefined)).toBe("");
+ expect(formatNumber(NaN)).toBe("");
+ expect(formatNumber(Infinity)).toBe("");
+ expect(formatNumber(0)).toBe("0"); // a real zero is a value, not a missing one
+ });
+
+ it("carries the UI language into the channel total-hours label", () => {
+ i18nStub.language = "hu";
+ expect(formatTotalHours(12345 * 3600)).toBe(`${new Intl.NumberFormat("hu").format(12345)} h`);
+ });
+});
+
describe("formatRuntime", () => {
const CASES: [number | null | undefined, string][] = [
[null, ""],
diff --git a/frontend/src/lib/format.ts b/frontend/src/lib/format.ts
index 16e7bf9d..0dde20e3 100644
--- a/frontend/src/lib/format.ts
+++ b/frontend/src/lib/format.ts
@@ -132,7 +132,28 @@ export function formatEta(seconds: number): string {
export function formatTotalHours(sec: number): string {
if (!sec) return "—";
const h = Math.round(sec / 3600);
- return h >= 1 ? `${h.toLocaleString()} h` : `${Math.max(1, Math.round(sec / 60))} m`;
+ return h >= 1 ? `${formatNumber(h)} h` : `${Math.max(1, Math.round(sec / 60))} m`;
+}
+
+// One grouped-number formatter per language, built lazily — the same reason as the relative-time
+// formatters above: the stats tables and the feed format a number per row, and constructing an Intl
+// formatter is the expensive part. Keyed by language because the user can switch it at runtime.
+const numberFormatters = new Map();
+
+/** A grouped number in the UI language ("1,234,567" in English, "1 234 567" in Hungarian). A bare
+ * `n.toLocaleString()` groups in the BROWSER's locale instead, so an English UI in a Hungarian
+ * browser showed space-grouped figures and vice versa — the number half of the same defect
+ * `formatDateTime` fixes for dates. Empty string for a missing/non-finite value, so a caller's
+ * `|| "—"` fallback covers it like a missing one. */
+export function formatNumber(n: number | null | undefined): string {
+ if (n == null || !Number.isFinite(n)) return "";
+ const lang = i18n.language;
+ let formatter = numberFormatters.get(lang);
+ if (!formatter) {
+ formatter = new Intl.NumberFormat(lang);
+ numberFormatters.set(lang, formatter);
+ }
+ return formatter.format(n);
}
export function formatViews(n: number | null): string {