fix(i18n): numbers, units, dates and order in the UI language, and after a switch (E30 S3)
Every locale formatter takes the language as an argument. Under the React
Compiler a formatter that read the i18n singleton was memoized on its other
arguments, so a card kept "2 hr 4 min" after a switch to Hungarian; plexLang()
had the same flaw and left Plex queries in the old language. Components now
take the language from useTranslation, and the signature makes forgetting it
a type error.
- ratings, file sizes, stream stats: the language's decimal mark ("8,3")
- view and subscriber counts compact in the language ("1,2 E")
- seconds as the language's unit ("6 mp") in the sliders and the stats
- a person's birth and death dates as dates, not ISO strings
- A-Z lists by the shown name in the language's alphabet (compareText),
the tag catalog re-sorted by its translated names
- lint local/locale-format (was date-format) also refuses Intl.NumberFormat
outside lib/format.ts, localeCompare, and a component reading the language
off the i18n singleton
This commit is contained in:
@@ -1,4 +1,5 @@
|
||||
import { healSort, type SortOption, type SortState } from "./columnSort";
|
||||
import { compareText } from "./collate";
|
||||
|
||||
// Plex's sort vocabulary, source-agnostic like the feed's — a `SortOption[]` fed to the shared
|
||||
// SortControl. Direction lives in the SortState (no more sibling `sortDir` on PlexFilters); the wire
|
||||
@@ -25,12 +26,16 @@ function plexSortKeys(scope: string): string[] {
|
||||
* SortState would otherwise corrupt the shared fallback for every caller. */
|
||||
export const PLEX_SORT_FALLBACK: SortState = Object.freeze({ key: "title", dir: "asc" as const });
|
||||
|
||||
/** Labelled, alpha-ordered options for the SortControl. `label` resolves each key (i18n
|
||||
* `plex.sort.<key>`). */
|
||||
export function plexSortOptions(scope: string, label: (key: string) => string): SortOption[] {
|
||||
/** Labelled, alpha-ordered options for the SortControl, in the UI language's alphabet. `label`
|
||||
* resolves each key (i18n `plex.sort.<key>`). */
|
||||
export function plexSortOptions(
|
||||
scope: string,
|
||||
label: (key: string) => string,
|
||||
lang: string,
|
||||
): SortOption[] {
|
||||
return plexSortKeys(scope)
|
||||
.map((key) => ({ key, label: label(key) }))
|
||||
.sort((a, b) => a.label.localeCompare(b.label));
|
||||
.sort((a, b) => compareText(a.label, b.label, lang));
|
||||
}
|
||||
|
||||
/** Heal a stored sort against a scope's available keys, collapsing an out-of-scope key to the default.
|
||||
|
||||
Reference in New Issue
Block a user