diff --git a/frontend/src/modules/playlists/Playlists.dom.test.tsx b/frontend/src/modules/playlists/Playlists.dom.test.tsx
index 2b30390a..d4c3136c 100644
--- a/frontend/src/modules/playlists/Playlists.dom.test.tsx
+++ b/frontend/src/modules/playlists/Playlists.dom.test.tsx
@@ -663,7 +663,9 @@ describe("Playlists — removing a row, and undoing it", () => {
// removal may notify too.
const lastToast = () =>
h.notify.mock.calls
- .map((c) => c[0] as { message: NotifText; action?: { label: string; onClick: () => void } })
+ .map(
+ (c) => c[0] as { message: NotifText; action?: { label: NotifText; onClick: () => void } },
+ )
.filter((n) => "key" in n.message && n.message.key === "playlists.removedToast")
.pop()!;
// The list's keys are live once its effect has registered it (`data-nav-list`), a passive effect that
@@ -690,7 +692,7 @@ describe("Playlists — removing a row, and undoing it", () => {
await waitFor(() =>
expect(lastToast().message).toEqual(msg("playlists.removedToast", { title: raw("Video B") })),
);
- expect(lastToast().action?.label).toBe("common.undo");
+ expect(lastToast().action?.label).toEqual(msg("common.undo"));
act(() => lastToast().action!.onClick());
// Index 1 of the STORED order: where it was, not the end of the list.
await waitFor(() => expect(api.addToPlaylist).toHaveBeenCalledWith(1, "B", 1));
diff --git a/frontend/src/modules/playlists/Playlists.tsx b/frontend/src/modules/playlists/Playlists.tsx
index 3ddd5be6..9e92bd80 100644
--- a/frontend/src/modules/playlists/Playlists.tsx
+++ b/frontend/src/modules/playlists/Playlists.tsx
@@ -547,7 +547,7 @@ function PlaylistDetail() {
level: "success",
message: msg("playlists.removedToast", { title: raw(video.title ?? "") }),
action: {
- label: t("common.undo"),
+ label: msg("common.undo"),
// ONE request that puts it back at its index (the server renumbers around it): an append
// plus a whole-list reorder would land it at the end whenever the second call failed. The
// index is worked out against the list as it is NOW, fetched fresh.
diff --git a/frontend/src/modules/plex/usePlexPlaylistEdits.dom.test.tsx b/frontend/src/modules/plex/usePlexPlaylistEdits.dom.test.tsx
index 04f2630c..0971e543 100644
--- a/frontend/src/modules/plex/usePlexPlaylistEdits.dom.test.tsx
+++ b/frontend/src/modules/plex/usePlexPlaylistEdits.dom.test.tsx
@@ -15,8 +15,11 @@ vi.mock("react-i18next", async (importOriginal) => ({
}));
const { notify } = vi.hoisted(() => ({
notify: vi.fn(
- (_n: { level: string; message: NotifText; action?: { label: string; onClick: () => void } }) =>
- 0,
+ (_n: {
+ level: string;
+ message: NotifText;
+ action?: { label: NotifText; onClick: () => void };
+ }) => 0,
),
}));
vi.mock("../../lib/notifications", async (importOriginal) => ({
@@ -149,7 +152,7 @@ describe("usePlexPlaylistEdits · the removal", () => {
expect(toast.message).toEqual(
msg("plex.playlist.removedToast", { title: raw("Show · Season 1") }),
);
- expect(toast.action!.label).toBe("common.undo");
+ expect(toast.action!.label).toEqual(msg("common.undo"));
act(() => toast.action!.onClick());
await waitFor(() => expect(add).toHaveBeenCalledTimes(1));
expect(add).toHaveBeenCalledWith(5, ["2", "4"], [1, 3]);
diff --git a/frontend/src/modules/plex/usePlexPlaylistEdits.ts b/frontend/src/modules/plex/usePlexPlaylistEdits.ts
index 62ba4b34..72e32a27 100644
--- a/frontend/src/modules/plex/usePlexPlaylistEdits.ts
+++ b/frontend/src/modules/plex/usePlexPlaylistEdits.ts
@@ -13,7 +13,7 @@ import { reinsertAt } from "../../lib/reinsert";
* Split from `PlexPlaylistView` so the failure paths are reachable from a test: the reorder is
* driven by a dnd-kit drag, and neither of its sensors activates under jsdom. */
export function usePlexPlaylistEdits(playlistId: number) {
- const { t, i18n } = useTranslation();
+ const { i18n } = useTranslation();
const qc = useQueryClient();
const [busy, setBusy] = useState(false);
// The rows' titles are in the reader's language, so the cache entry is per language — and ONE
@@ -112,7 +112,7 @@ export function usePlexPlaylistEdits(playlistId: number) {
level: "success",
message: msg("plex.playlist.removedToast", { title }),
action: {
- label: t("common.undo"),
+ label: msg("common.undo"),
onClick: () =>
void qc
.fetchQuery({
diff --git a/frontend/src/shell/useAccessRequestsNudge.ts b/frontend/src/shell/useAccessRequestsNudge.ts
index 4fec2375..49e642a7 100644
--- a/frontend/src/shell/useAccessRequestsNudge.ts
+++ b/frontend/src/shell/useAccessRequestsNudge.ts
@@ -1,5 +1,4 @@
import { useEffect } from "react";
-import { useTranslation } from "react-i18next";
import type { Me } from "../lib/api";
import type { Page } from "../lib/urlState";
import { msg, notify, removeByMetaKind } from "../lib/notifications";
@@ -8,13 +7,11 @@ import { focusAccessRequestsTab } from "../lib/adminUsersTab";
type SetPage = (next: Page, then?: () => void) => void;
export function useAccessRequestsNudge(me: Me | null | undefined, setPage: SetPage): void {
- const { t } = useTranslation();
// Nudge admins when access requests are waiting (in lieu of a server-push bell). Keyed on the
// pending COUNT so it re-resolves the moment an approval/denial changes it — not only on a
// fresh load (which is why the notice used to linger until F5 after an approval).
- // Honest deps, and `t` among them is a fix rather than a concession: the nudge is a persisted
- // toast whose text is translated at issue time, so a language switch must re-issue it. It did not
- // before — the notice stayed in the old language until the count changed.
+ // No `t` among the deps: the nudge keeps what it says (its title, message and button), said in the
+ // reader's language each time it is shown, so a language switch needs no re-issue.
const role = me?.role;
const pendingInvites = me?.pending_invites ?? 0;
const pendingActivations = me?.pending_activations ?? 0;
@@ -36,7 +33,7 @@ export function useAccessRequestsNudge(me: Me | null | undefined, setPage: SetPa
// gets a click via the action.
meta: { kind: "access-requests" },
action: {
- label: t("common.accessRequestsReview"),
+ label: msg("common.accessRequestsReview"),
onClick: () => {
focusAccessRequestsTab();
// Clicked inside whatever overlay hosts the toast; setPage closes it before pushing.
@@ -45,5 +42,5 @@ export function useAccessRequestsNudge(me: Me | null | undefined, setPage: SetPa
},
});
}
- }, [role, pendingInvites, pendingActivations, t, setPage]);
+ }, [role, pendingInvites, pendingActivations, setPage]);
}