refactor: component files export only components; lint fails on a warning

The 43 react-refresh/only-export-components warnings the gate let through meant an edit to a provider (or AnchoredPopover, Toaster, plexDetailUi, …) could not be hot-swapped: Fast Refresh reloads a module that also exports hooks or helpers. - Each provider's contexts, the types its hooks return and the hooks themselves live in a sibling context module (navigationContext.ts, channelsContext.ts, …); the provider file keeps the component. loadAccountFilters moved next to the feed filters' defaults (feedFiltersInit.ts), following navigationInit/playlistsInit. - Helpers that sat in component files have their own modules: welcomeMode, downloadTitle, plexPlayable, channelSync, ui/anchoredPopoverHooks, ui/pageToolbarSlot, ui/pagerContent, ui/toastLevels, ui/overlayOrder, ui/tableAlign, lib/plexDetail; the cells of the channel columns and the registry's page wrappers are components files of their own (channelCells, modulePages). - usePersistedTab, an alias of useAccountPersistedState, is gone; its callers use the original. npm run lint is now eslint --max-warnings 0, so a warning fails the gate like an error does.
2026-09-17 02:59:09 +02:00
parent 569190480d
commit c3d88d9b20
158 changed files with 1600 additions and 1431 deletions
@@ -0,0 +1,106 @@
+import { useTranslation } from "react-i18next";
+import { Check, Eye, EyeOff, History, UserMinus } from "lucide-react";
+import type { ManagedChannel } from "../lib/api";
+import { formatNumber } from "../lib/format";
+import Tooltip from "./ui/Tooltip";
+import { isFullySynced } from "./channelSync";
+
+// The Channels-manager cells that are components in their own right (they read i18n), split out of
+// channelColumns so that file holds only the column factory and its predicates (Fast Refresh).
+
+// The Stored count, with a "fully synced" ✓ charm to the left of the number when recent uploads and
+// full history are both in — folding the retired Sync column's at-a-glance status into the value it
+// describes. Full detail stays in the hover tooltip.
+export function StoredCell({ c }: { c: ManagedChannel }) {
+  const { t } = useTranslation();
+  return (
+    <span className="inline-flex items-center justify-end gap-1 text-muted tabular-nums">
+      {isFullySynced(c) && (
+        <Tooltip hint={t("channels.row.fullySyncedHint")}>
+          <Check
+            role="img"
+            className="w-3.5 h-3.5 text-accent shrink-0 cursor-help"
+            aria-label={t("channels.row.fullySynced")}
+          />
+        </Tooltip>
+      )}
+      {formatNumber(c.stored_videos)}
+    </span>
+  );
+}
+
+export function ActionsCell({
+  c,
+  isAdmin,
+  canWrite,
+  onHide,
+  onDeep,
+  onReset,
+  onUnsubscribe,
+}: {
+  c: ManagedChannel;
+  isAdmin: boolean;
+  canWrite: boolean;
+  onHide: () => void;
+  onDeep: () => void;
+  onReset: () => void;
+  onUnsubscribe: () => void;
+}) {
+  const { t } = useTranslation();
+  // Admins get a "reset" trigger that re-fetches the channel from scratch regardless of
+  // state — always actionable. Regular users get the per-user "request full history" opt-in,
+  // which only applies until the back-catalog is in (or already coming for everyone).
+  const done = c.backfill_done;
+  const requested = !done && c.deep_requested;
+  const optInActionable = !done && !c.deep_in_queue;
+  const backfillHint = isAdmin
+    ? t("channels.row.resetHint")
+    : c.deep_in_queue
+      ? t("channels.row.queuedByOtherHint")
+      : requested
+        ? t("channels.row.queuedRequestedHint")
+        : done
+          ? t("channels.row.fullHint")
+          : t("channels.row.backfillThisHint");
+  const enabled = isAdmin || optInActionable;
+  return (
+    <div className="inline-flex items-center gap-2">
+      <Tooltip hint={backfillHint}>
+        <button
+          onClick={!enabled ? undefined : isAdmin ? onReset : onDeep}
+          disabled={!enabled}
+          className={`shrink-0 transition ${
+            requested
+              ? "text-accent"
+              : enabled
+                ? "text-muted hover:text-fg"
+                : "text-muted/40 cursor-default"
+          }`}
+          aria-label={isAdmin ? t("channels.row.resetBackfill") : t("channels.row.backfillThis")}
+        >
+          <History className="w-4 h-4" />
+        </button>
+      </Tooltip>
+      <Tooltip hint={c.hidden ? t("channels.row.hiddenHint") : t("channels.row.hideHint")}>
+        <button
+          onClick={onHide}
+          className="text-muted hover:text-fg shrink-0"
+          aria-label={c.hidden ? t("channels.row.unhide") : t("channels.row.hideFromFeed")}
+        >
+          {c.hidden ? <EyeOff className="w-4 h-4" /> : <Eye className="w-4 h-4" />}
+        </button>
+      </Tooltip>
+      {canWrite && (
+        <Tooltip hint={t("channels.row.unsubscribeHint")}>
+          <button
+            onClick={onUnsubscribe}
+            className="text-muted hover:text-danger shrink-0"
+            aria-label={t("channels.row.unsubscribeOnYoutube")}
+          >
+            <UserMinus className="w-4 h-4" />
+          </button>
+        </Tooltip>
+      )}
+    </div>
+  );
+}