refactor(ui): every function compiles under the React Compiler but VirtualGrid, and react-hooks/refs is on
E32 S4 — the burn-down from 29 skipped functions to 1: - try/finally (26 sites): the cleanup runs after a try/catch; steps that return early moved into their own function (push, the setup wizard's next, the share page's unlock). - A conditional, loop or optional call inside a try skips the function too, and react-hooks/todo does not see it: the value is computed before the try, or the try lives in a module-level helper (config writes, clip queueing, clipboard, frame counts, seekable end, YouTube player times). - The two exhaustive-deps suppressions are gone. useYtProgress takes its per-item snapshot through one effect event, read once when the player is built; PlexPlayer's unmount relies on the leaving-the-item cleanup for the generation bump it duplicated. - What the skips hid: PlexPlayer's 17 render-phase ref writes (useLatest), its tracks popover alias, the loadSession self-reference (declared early, set after commit); PlayerModal's session-position read during render (now where the player starts), navRef/modeRef writes, and a description helper that ran a ref-carrying callback during render (now PlayerDescription); SavedViewsProvider's latest-cfg ref, and its setState in the seed effect (preferSticky now prefers the starred default among same-filter views, so the seed needs no sticky write — test seen red on the old helper). - A store's hook was called `use()`, which the compiler does not know as a hook: inside the newly compiled usePlaylistActions it was memoized, ran on the first render alone, and the playlist rail threw "rendered fewer hooks" on its second render. Renamed to `useValue()` everywhere; the old contract test claimed the call was safe inside any `use…` function, which was false — replaced by a render test that is red under the old name. - PlexPlayer's palette ref was written and never read since the Backspace guard moved to the layer stack: removed. react-hooks/refs is back at error with no exception. The ratchet lists only VirtualGrid (IncompatibleLibrary) and pins both players as compiled. No size or complexity ceiling was raised.
This commit is contained in:
@@ -0,0 +1,51 @@
|
||||
// @vitest-environment jsdom
|
||||
//
|
||||
// A store is read from React through `useValue()`, a name the React Compiler knows as a hook. Its
|
||||
// old name, `use()`, it did not: the call was compiled as an ordinary one and memoized, so it ran
|
||||
// on the first render alone. Read straight from a component, Back to top never re-rendered (E28);
|
||||
// read inside a hook that compiles memo scopes around it, usePlaylistActions rendered fewer hooks
|
||||
// on its second render and threw (E32 S4, the moment that hook started to compile). Vitest builds
|
||||
// with the same compiler as the app (reactPlugin), so this renders the compiled code.
|
||||
import { describe, it, expect, afterEach } from "vitest";
|
||||
import { render, screen, act, cleanup } from "@testing-library/react";
|
||||
import { useState } from "react";
|
||||
import { createStore } from "./store";
|
||||
|
||||
afterEach(cleanup);
|
||||
|
||||
const count = createStore(0);
|
||||
|
||||
// A hook shaped like usePlaylistActions: other hooks around the read, and a callback built from it.
|
||||
function useCountLabel(prefix: string) {
|
||||
const [step] = useState(1);
|
||||
const value = count.useValue();
|
||||
const next = () => count.set(value + step);
|
||||
return { label: `${prefix}${value}`, next };
|
||||
}
|
||||
|
||||
function Counter() {
|
||||
const { label, next } = useCountLabel("n=");
|
||||
return <button onClick={next}>{label}</button>;
|
||||
}
|
||||
|
||||
function Bare() {
|
||||
return <span>{`bare=${count.useValue()}`}</span>;
|
||||
}
|
||||
|
||||
describe("a store read from React", () => {
|
||||
it("re-renders a compiled hook and a compiled component on every change", () => {
|
||||
act(() => count.set(0));
|
||||
render(
|
||||
<>
|
||||
<Counter />
|
||||
<Bare />
|
||||
</>,
|
||||
);
|
||||
act(() => count.set(1));
|
||||
expect(screen.getByRole("button").textContent).toBe("n=1");
|
||||
expect(screen.getByText("bare=1")).toBeTruthy();
|
||||
act(() => screen.getByRole("button").click());
|
||||
expect(screen.getByRole("button").textContent).toBe("n=2");
|
||||
expect(screen.getByText("bare=2")).toBeTruthy();
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user