perf(watch): a shared link loads the player, not the app
A /watch link is opened by whoever it was sent to — signed out, often on a phone on mobile data — and it booted through main.tsx: every app provider, the app's i18n (every locale of every area), the flag sprites, ~392 KB gzip before the player could start. It now has its own HTML entry, watch.html → watchMain.tsx, which imports WatchPage and what it renders; the server hands every /watch/ path that page (the OG block injected as before), and vite dev does the same. Measured on the build: /watch JS 290 → 87 KB gzip, CSS 104 → 19 KB; the app's own bytes unchanged. Two leaks had to go for that: lib/format imported the app's i18n for one "just now" string (the relative-time formatters now take `t`, like the file's other t-formatters), and the boundary's crash copy came from the same i18n (CrashBoundary takes its copy; ErrorBoundary is the app's wrapper, the watch entry gives it the page's own strings). The page's popover tree went too: it renders no popover. Held by: a contract test walking the entry's runtime imports, naming the path to anything only the app may load (red on a planted i18n import in lib/format), and holding watch.html's head equal to index.html's; a DB-lane test that every /watch/ path gets the player's page with the link's OG tags and app paths get the app (red on the old routing). Screenshots at 375 px, EN and HU, video / audio / password / gone / wrong password / unlocked: identical to the old entry's, bar the video's buffered bar.
This commit is contained in:
+10
-16
@@ -29,15 +29,15 @@ installClientLog(appCopyOf);
|
||||
// A tab from before the last release reloads onto the new build instead of crashing on a lazy chunk.
|
||||
installStaleBuildReload();
|
||||
|
||||
// Split by top-level route so each entry point is its own chunk: a public /watch share link or a
|
||||
// legal page never downloads the authenticated app bundle, and the app never carries them either.
|
||||
// The legal pages live outside the App tree (no /api/me) so Google's consent screen and reviewers
|
||||
// can fetch them directly; the watch page is a login-free public player. Reached by full-page
|
||||
// navigation (plain <a href>), so a simple pathname switch is enough — no router needed.
|
||||
// Split by top-level route so each entry point is its own chunk: a legal page never downloads the
|
||||
// authenticated app bundle, and the app never carries it either. The legal pages live outside the
|
||||
// App tree (no /api/me) so Google's consent screen and reviewers can fetch them directly. Reached by
|
||||
// full-page navigation (plain <a href>), so a simple pathname switch is enough — no router needed.
|
||||
// A public /watch link is not here at all: it has its own HTML entry (watch.html → watchMain.tsx),
|
||||
// so the friend it was sent to never loads this file's providers, i18n or CSS imports.
|
||||
const App = lazyWithPreload(() => import("./App"));
|
||||
const PrivacyPolicy = lazy(() => import("./components/legal/PrivacyPolicy"));
|
||||
const Terms = lazy(() => import("./components/legal/Terms"));
|
||||
const WatchPage = lazy(() => import("./components/WatchPage"));
|
||||
// The design lab: the living style guide, rendered with the app's real CSS so a design decision
|
||||
// is taken on what will ship. DEV only — Vite folds the condition to `false` in a production build,
|
||||
// the import becomes dead code and the chunk is never emitted (devOnlyGuard fails the build if it is).
|
||||
@@ -46,7 +46,7 @@ const DesignLab = import.meta.env.DEV ? lazy(() => import("./design-lab/DesignLa
|
||||
const queryClient = createQueryClient();
|
||||
|
||||
// Baseline theme so the token CSS vars (--bg/--surface/--accent/…) resolve on first paint — including
|
||||
// the standalone public pages (/watch, /privacy, /terms) that render outside <App> and never call
|
||||
// the standalone public pages (/privacy, /terms) that render outside <App> and never call
|
||||
// applyTheme. The app overrides this with the user's saved theme once it mounts.
|
||||
const de = document.documentElement.dataset;
|
||||
de.theme ||= "dark";
|
||||
@@ -54,8 +54,7 @@ de.scheme ||= "midnight";
|
||||
|
||||
const path = window.location.pathname;
|
||||
const isLab = DesignLab !== null && path === "/design-lab";
|
||||
const isPublicPage =
|
||||
path === "/privacy" || path === "/terms" || path.startsWith("/watch/") || isLab;
|
||||
const isPublicPage = path === "/privacy" || path === "/terms" || isLab;
|
||||
// Fetch the app chunk NOW, alongside BootGate's identity probe, instead of only once the gate opens:
|
||||
// the two waits then overlap rather than queue, and the gate usually opens straight onto the app. A
|
||||
// failed fetch is left to the render's own load, which retries it and reports to the ErrorBoundary.
|
||||
@@ -69,11 +68,6 @@ const root =
|
||||
<PrivacyPolicy />
|
||||
) : path === "/terms" ? (
|
||||
<Terms />
|
||||
) : path.startsWith("/watch/") ? (
|
||||
// FloatingTree so the public player's own popovers dispatch Escape/outside-press topmost-only.
|
||||
<FloatingTree>
|
||||
<WatchPage />
|
||||
</FloatingTree>
|
||||
) : (
|
||||
<QueryClientProvider client={queryClient}>
|
||||
{/* One tree for the whole app: every anchored popover registers as a node so Escape and
|
||||
@@ -119,8 +113,8 @@ const root =
|
||||
|
||||
createRoot(document.getElementById("root")!).render(
|
||||
<React.StrictMode>
|
||||
{/* Around EVERY entry, the public ones too: a crash on a shared /watch link, or its chunk gone
|
||||
twice over after a release (lib/staleBuild), left a blank white page with no way on. */}
|
||||
{/* Around EVERY entry, the public ones too: a crash, or a chunk gone twice over after a release
|
||||
(lib/staleBuild), left a blank white page with no way on. */}
|
||||
<ErrorBoundary>
|
||||
<Suspense fallback={<div style={{ minHeight: "100dvh" }} />}>{root}</Suspense>
|
||||
</ErrorBoundary>
|
||||
|
||||
Reference in New Issue
Block a user