test(backfill): lock the per-page durability and reserve-guard properties
Deep-review round 1 found the new tests asserted end-state only, so both safety mechanisms this change adds were untested (a regression would ship green): - Per-page cursor durability: add test_a_mid_run_failure_leaves_the_prior_page _durably_committed, which fails the 2nd page's fetch after page 1 committed and asserts the cursor + rows are already persisted (re-read via db.expire). Mutation-verified: reverting to a single end-of-loop commit makes it fail while the pre-existing paging tests stay green — the property the original test could not distinguish. - Reserve guard: add test_backfill_reserve_reached_tracks_the_boundary, driving real record_usage spend across the 9000/2000 default boundary and asserting the un-mocked quota.backfill_reserve_reached() flips at exactly remaining<=reserve. Full backend suite: 244 passed, 2 skipped (network-gated).
This commit is contained in:
@@ -55,3 +55,15 @@ def test_log_action_survives_caller_rollback(db):
|
||||
assert events[0].units == 0
|
||||
# ... and the caller's uncommitted user is gone.
|
||||
assert db.scalar(select(func.count()).select_from(User)) == 1
|
||||
|
||||
|
||||
def test_backfill_reserve_reached_tracks_the_boundary(db):
|
||||
# The shared yield gate for every backfill/explore/revalidation path: True once today's remaining
|
||||
# budget is at or below the backfill reserve. It reads in its OWN session, so it must reflect
|
||||
# record_usage's independently-committed spend — and the boundary is inclusive (<=). Defaults:
|
||||
# quota_daily_budget 9000, backfill_quota_reserve 2000 -> reached once 7000 units are used.
|
||||
assert quota.backfill_reserve_reached() is False # 0 used, remaining 9000
|
||||
quota.record_usage(6999) # remaining 2001, just above the reserve
|
||||
assert quota.backfill_reserve_reached() is False
|
||||
quota.record_usage(1) # remaining 2000, exactly at the reserve
|
||||
assert quota.backfill_reserve_reached() is True # boundary is <=, so the reserve is reached
|
||||
|
||||
Reference in New Issue
Block a user