fix(keys): epic-end review round 1 — Back, menus and dialogs keep the focus where it belongs
Deep-review of E11 (19 raised, 14 confirmed; 2 refuted, 3 latent test-hardening notes dropped). - Back from a sub-view (a Plex show page, a Messages thread) restores the item it was opened from even when focus was still inside the view: the first attempt now waits one task, past the sub-view's own popstate listener (measured in Chrome: it left focus on <body>). - The restore listener is installed at load, so the first Back after a reload finds it; a push cancels a restore still waiting for the last landing's lists. - Navigating over an overlay asks it again, a render apart, while its entry stays: the Plex player peels one panel per Back step, so Shift+W over info + stats closed one panel and dropped the navigation. - j/k: a native <button> item keeps its own Tab stop; landing twice on the same item no longer leaks its tabindex; after the focused item is removed (a hidden card) the next j goes on from its slot when that slot is on screen. - An abandoned `g` no longer swallows a modifier chord (g, then Mod+K opened the browser search). - A hover card above a dialog no longer switches its Tab trap off (player, Modal, wizard, Lightbox): new layerStack `anyBlockingLayerAbove`. - "Manage views…" closes its menu before opening the dialog, through a shared `closeThenAct` that ActionMenu now uses too. - Copy: the EN welcome says "Feed"; the EN unreachable reason no longer claims a change; stale comments about PlayerModal's scroll lock and dialog contract.
This commit is contained in:
@@ -163,6 +163,36 @@ describe("closeOverlaysThenNavigate", () => {
|
||||
}
|
||||
});
|
||||
|
||||
// An overlay's Back callback is a Back STEP: the Plex player keeps its panels on one entry and peels
|
||||
// one per call. Called once, the entry stayed and the navigation was dropped 1.5 s later — `i`, `d`,
|
||||
// Shift+W in the player closed the info panel and nothing else (deep-review E11 round 1).
|
||||
it("asks again, a render apart, when one call peels only a step off the overlay", async () => {
|
||||
const back = stubBack();
|
||||
try {
|
||||
let steps = 2;
|
||||
const calls: number[] = [];
|
||||
const holder: { unmount?: () => void } = {};
|
||||
const r = renderHook(() =>
|
||||
useBackToClose(() => {
|
||||
calls.push(steps);
|
||||
if (--steps === 0) holder.unmount?.();
|
||||
}),
|
||||
);
|
||||
holder.unmount = r.unmount;
|
||||
await settle();
|
||||
const navigate = vi.fn();
|
||||
act(() => closeOverlaysThenNavigate(navigate));
|
||||
expect(calls).toEqual([2]);
|
||||
await act(async () => {
|
||||
await new Promise((res) => setTimeout(res, 300));
|
||||
});
|
||||
expect(calls).toEqual([2, 1]); // never called again once the entry is gone
|
||||
expect(navigate).toHaveBeenCalledTimes(1);
|
||||
} finally {
|
||||
back.mockRestore();
|
||||
}
|
||||
});
|
||||
|
||||
// The old helper ran after "a popstate" OR a 250 ms fallback, whichever came first — so a reclaim
|
||||
// slower than the fallback undid the navigation. It must wait for the history, not the clock.
|
||||
it("waits for a back() still in flight instead of pushing under it", async () => {
|
||||
|
||||
Reference in New Issue
Block a user