fix(downloads): GIF review round 2 — cap as sent, shown length, retry, Join reason
The panels judge a GIF's length in whole milliseconds between the ends as sent, the server's own rule, and a refused length reads rounded up. A shared picture says it failed only once its retry failed too. Join's reason shows on a key's focus; the editor's failure toasts name GIFs. The edit route's cap is test-held, and DESIGN.md records the GIF UI.
This commit is contained in:
+18
-2
@@ -53,8 +53,24 @@ export function gifEstimateText(est: { lo: number; hi: number }, lang: string) {
|
||||
* pass the cap (refused when it does), it may be too big to move in a link preview, or fine. */
|
||||
export type GifVerdict = "too_long" | "may_fail" | "no_preview" | "ok";
|
||||
|
||||
export function gifVerdict(seconds: number, est: { hi: number }): GifVerdict {
|
||||
if (seconds > GIF_MAX_S + 0.0005) return "too_long";
|
||||
/** A time as the request sends it: to the millisecond. */
|
||||
export const atMs = (s: number) => Math.round(s * 1000) / 1000;
|
||||
|
||||
/** A range's length in whole milliseconds, between its ends as the request sends them: the length
|
||||
* the server judges (gif.too_long), so a range the panel allows is never refused for its length,
|
||||
* and none it refuses would have been made. */
|
||||
export const spanMs = (start: number, end: number) =>
|
||||
Math.round(end * 1000) - Math.round(start * 1000);
|
||||
|
||||
/** A range's length to show beside a verdict: over the cap it is rounded up to the tenth, so a
|
||||
* refused range never reads as one the cap allows ("0:30.0" for 30.03 s). */
|
||||
export function gifShownLength(start: number, end: number): number {
|
||||
const ms = spanMs(start, end);
|
||||
return ms > GIF_MAX_S * 1000 ? Math.ceil(ms / 100) / 10 : ms / 1000;
|
||||
}
|
||||
|
||||
export function gifVerdict(start: number, end: number, est: { hi: number }): GifVerdict {
|
||||
if (spanMs(start, end) > GIF_MAX_S * 1000) return "too_long";
|
||||
// Judged on the high end as shown (whole megabytes): "about 12–30 MB" beside "it may pass 30 MB"
|
||||
// would contradict itself, and the estimate is no finer than that anyway.
|
||||
const hi = Math.round(est.hi / MB) * MB;
|
||||
|
||||
Reference in New Issue
Block a user