peter
10c0ca4cf7
Twelve mails carried hardcoded English while the app itself has enforced HU/EN parity since E5.
A mail is the one user-facing surface nobody can re-render by switching the UI language: it arrives
once, in whatever language we picked, and stays that way. That made the epic's own headline mail —
"one mail, one click" — English for a Hungarian reader.
The text moved to a catalog (`mailtext.py`) with a `text(key, lang, **vars)` renderer, and the parity
rule is now a test rather than a habit: every key must carry both languages AND the same
`{placeholders}`. A translation that drops `{link}` sends a mail with no link in it; one that invents
a placeholder raises inside a background task nobody is watching. Both are silent in production.
Every `send_*` takes the language as its second argument, resolved by the REQUEST handler and never
inside the mail — these all run as background tasks, after the request's session is gone, which is
the same reason the approval mail computes its link in the handler.
Where the language comes from, in order: the account's own preference; failing that, the language the
person asked us in; failing that, English. The middle one is new — `invites.lang`, migration `0082` —
because the mails an access request produces go to an address that usually has no account yet, and
the signal does exist: the page their form was submitted from, or the locale Google reported for a
sign-in we refused. Captured rather than derived, for the third time in this epic (`google_email` in
S3, `preferences.language` in S6 taught the same lesson): a signal that exists only in one moment
cannot be backfilled later. So the admin is asked in exactly one place — the invitation to an address
they typed in themselves, where nobody has ever told us anything.
That send is now a dialog rather than a bare click, which is also where the "you already wrote to
them" warning belongs — it used to live only in a tooltip the admin may never hover, guarding the one
action whose failure mode is mailing a real person twice.
S6's registration `lang` field turned out to be dead on arrival: the backend accepted it, the
frontend never sent it, so every account has been storing nothing. The request builders now stamp the
UI language themselves — a signal that has to be passed in by every caller is one every caller can
forget, which is exactly how it shipped unset.
Admins are notified one mail per language group instead of one blast to everyone. They are people
with their own UI language; a single message would have to pick one of them and be wrong for the rest.
Also removes a duplicated `invited_at` column declaration on `Invite` (two identical definitions
landed in S6).
35 lines
1.4 KiB
Python
35 lines
1.4 KiB
Python
"""invites.lang — the language this person asked us in
|
|
|
|
Revision ID: 0082_invite_lang
|
|
Revises: 0081_invite_invited_at
|
|
Create Date: 2026-09-05
|
|
|
|
The mails an access request produces — approved, denied, invited — go to an address that often has
|
|
no account yet, so there is no `preferences.language` to read. The signal does exist, though, and
|
|
only at the moment of the request: the language of the page the form was submitted from, or the
|
|
locale Google reported for a sign-in we refused. Recording it there is what lets the decision mail
|
|
answer in the requester's own language instead of an admin's guess about a stranger.
|
|
|
|
Captured rather than derived, for the third time in this epic: `preferences.language` (S6) and
|
|
`google_email` (S3) both taught that a signal which exists only in one moment cannot be backfilled
|
|
later. So no backfill here either — NULL means "we were never told", which is the honest state for
|
|
every historic row, and for every address an admin whitelists by hand. Those fall back to English
|
|
unless the admin picks otherwise on the invitation send.
|
|
"""
|
|
|
|
import sqlalchemy as sa
|
|
from alembic import op
|
|
|
|
revision: str = "0082_invite_lang"
|
|
down_revision: str | None = "0081_invite_invited_at"
|
|
branch_labels: str | None = None
|
|
depends_on: str | None = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
op.add_column("invites", sa.Column("lang", sa.String(length=8), nullable=True))
|
|
|
|
|
|
def downgrade() -> None:
|
|
op.drop_column("invites", "lang")
|