peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
91 lines
3.1 KiB
TypeScript
91 lines
3.1 KiB
TypeScript
// @vitest-environment jsdom
|
||
//
|
||
// A next-page call while that page is still loading joins it instead of sending it again:
|
||
// on prod every feed page went out 2–3 times with the same cursor.
|
||
import { InfiniteQueryObserver } from "@tanstack/react-query";
|
||
import { describe, expect, it } from "vitest";
|
||
|
||
import { mayReadAhead, NEXT_PAGE, nextPageOnClick } from "./nextPage";
|
||
import { createQueryClient } from "./queryClient";
|
||
|
||
function probe(sent: (string | null)[], delay = 5) {
|
||
return new InfiniteQueryObserver(createQueryClient(), {
|
||
queryKey: ["probe"],
|
||
initialPageParam: null as string | null,
|
||
queryFn: async ({ pageParam }) => {
|
||
sent.push(pageParam);
|
||
await new Promise((r) => setTimeout(r, delay));
|
||
return { next: `c${sent.length}` };
|
||
},
|
||
getNextPageParam: (last: { next: string }) => last.next,
|
||
});
|
||
}
|
||
|
||
describe("NEXT_PAGE", () => {
|
||
it("sends each page once when the read-ahead calls twice in a row", async () => {
|
||
const sent: (string | null)[] = [];
|
||
const observer = new InfiniteQueryObserver(createQueryClient(), {
|
||
queryKey: ["probe"],
|
||
initialPageParam: null as string | null,
|
||
queryFn: async ({ pageParam }) => {
|
||
sent.push(pageParam);
|
||
await new Promise((r) => setTimeout(r, 5));
|
||
return { next: `c${sent.length}` };
|
||
},
|
||
getNextPageParam: (last: { next: string }) => last.next,
|
||
});
|
||
const unsubscribe = observer.subscribe(() => {});
|
||
await observer.refetch();
|
||
|
||
// Two scroll frames before `isFetchingNextPage` reaches the component.
|
||
void observer.fetchNextPage(NEXT_PAGE);
|
||
await observer.fetchNextPage(NEXT_PAGE);
|
||
|
||
expect(sent).toEqual([null, "c1"]);
|
||
expect(observer.getCurrentResult().data?.pages).toHaveLength(2);
|
||
unsubscribe();
|
||
});
|
||
|
||
// The join takes ANY fetch in flight. During a background refetch (an invalidation, a
|
||
// poll) it reloads the pages already there and appends none — why a read-ahead waits it out.
|
||
it("joins a background refetch and appends no page", async () => {
|
||
const sent: (string | null)[] = [];
|
||
const observer = probe(sent);
|
||
const unsubscribe = observer.subscribe(() => {});
|
||
await observer.refetch();
|
||
|
||
void observer.refetch();
|
||
await observer.fetchNextPage(NEXT_PAGE);
|
||
|
||
expect(observer.getCurrentResult().data?.pages).toHaveLength(1);
|
||
unsubscribe();
|
||
});
|
||
});
|
||
|
||
describe("a read-ahead", () => {
|
||
it("waits while the list fetches anything", () => {
|
||
expect(mayReadAhead(true, false)).toBe(true);
|
||
expect(mayReadAhead(true, true)).toBe(false);
|
||
expect(mayReadAhead(false, false)).toBe(false);
|
||
});
|
||
});
|
||
|
||
describe("a next page asked for by a click", () => {
|
||
it("loads the page even while a background refetch runs", async () => {
|
||
const sent: (string | null)[] = [];
|
||
const observer = probe(sent);
|
||
const unsubscribe = observer.subscribe(() => {});
|
||
await observer.refetch();
|
||
|
||
void observer.refetch();
|
||
await observer.fetchNextPage(nextPageOnClick(false));
|
||
|
||
expect(observer.getCurrentResult().data?.pages).toHaveLength(2);
|
||
unsubscribe();
|
||
});
|
||
|
||
it("joins a next page already loading", () => {
|
||
expect(nextPageOnClick(true)).toBe(NEXT_PAGE);
|
||
});
|
||
});
|