peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
72 lines
2.4 KiB
TypeScript
72 lines
2.4 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// The detail the consented levels add — filter changes and what a player went through.
|
|
// Below Részletes they cost nothing and log nothing, except a media error, which is always a warning.
|
|
import { afterEach, describe, expect, it } from "vitest";
|
|
|
|
import { logFilterChange } from "./filterLog";
|
|
import { clear, events, setLevel } from "./log";
|
|
import { logMediaElement, logYouTubeError, logYouTubeState } from "./mediaLog";
|
|
|
|
afterEach(() => {
|
|
clear();
|
|
setLevel("INFO");
|
|
});
|
|
|
|
const attrsOf = (code: string) =>
|
|
events()
|
|
.filter((e) => e.event === code)
|
|
.map((e) => e.attrs);
|
|
|
|
describe("filter changes", () => {
|
|
it("are not logged at the base level", () => {
|
|
logFilterChange("feed", { tags: [3] }, "lofi");
|
|
expect(events()).toEqual([]);
|
|
});
|
|
|
|
it("log their values at DEBUG, but only whether there is a search", () => {
|
|
setLevel("DEBUG");
|
|
logFilterChange("feed", { tags: [3], sort: "newest", q: "lofi beats" }, "lofi beats");
|
|
expect(attrsOf("filter.change")).toEqual([
|
|
{ scope: "feed", tags: [3], sort: "newest", query_set: true },
|
|
]);
|
|
expect(JSON.stringify(events())).not.toContain("lofi");
|
|
});
|
|
|
|
it("log the typed search at TRACE, and never the display titles riding in a filter", () => {
|
|
setLevel("TRACE");
|
|
logFilterChange("plex", { filters: { collections: ["9"] }, collectionTitles: { 9: "Mine" } });
|
|
logFilterChange("plex", {}, "alien");
|
|
expect(attrsOf("filter.change")).toEqual([
|
|
{ scope: "plex", filters: { collections: ["9"] } },
|
|
{ scope: "plex", query: "alien" },
|
|
]);
|
|
});
|
|
});
|
|
|
|
describe("player events", () => {
|
|
it("a media error is a warning at every level; the rest waits for DEBUG", () => {
|
|
const video = document.createElement("video");
|
|
const detach = logMediaElement(video, "plex");
|
|
video.dispatchEvent(new Event("waiting"));
|
|
video.dispatchEvent(new Event("error"));
|
|
logYouTubeState(3, 12.4);
|
|
logYouTubeError(150);
|
|
expect(events().map((e) => [e.event, e.level])).toEqual([
|
|
["player.media_error", "WARNING"],
|
|
["player.media_error", "WARNING"],
|
|
]);
|
|
|
|
clear();
|
|
setLevel("DEBUG");
|
|
video.dispatchEvent(new Event("waiting"));
|
|
logYouTubeState(3, 12.4);
|
|
detach();
|
|
video.dispatchEvent(new Event("stalled"));
|
|
expect(attrsOf("player.media")).toEqual([
|
|
{ player: "plex", event: "waiting", at: 0 },
|
|
{ player: "youtube", event: "buffering", at: 12 },
|
|
]);
|
|
});
|
|
});
|