peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
101 lines
3.8 KiB
TypeScript
101 lines
3.8 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// One-click share: quickShareLink turns the row's Share button into a single action —
|
|
// ensure a public link (mint on demand, downloadable), copy it, and toast with an "open in new
|
|
// tab" action. These pin the branch matrix: reuse-vs-mint, copy-ok-vs-fail, and the create-failure path.
|
|
import { describe, it, expect, beforeEach, vi } from "vitest";
|
|
import { QueryClient } from "@tanstack/react-query";
|
|
|
|
// vi.mock is hoisted above these consts, so the mock fns must live in a hoisted block too.
|
|
const { downloadLinks, createDownloadLink, copyText, notify } = vi.hoisted(() => ({
|
|
downloadLinks: vi.fn(),
|
|
createDownloadLink: vi.fn(),
|
|
copyText: vi.fn(),
|
|
notify: vi.fn(),
|
|
}));
|
|
|
|
vi.mock("./api", () => ({ api: { downloadLinks, createDownloadLink } }));
|
|
vi.mock("./clipboard", () => ({ copyText }));
|
|
vi.mock("./notifications", () => ({ notify }));
|
|
|
|
import { quickShareLink } from "./downloads";
|
|
|
|
const t = (k: string) => k;
|
|
const origin = window.location.origin;
|
|
|
|
type ToastArg = {
|
|
level: string;
|
|
message: string;
|
|
action?: { label: string; onClick: () => void };
|
|
};
|
|
const firstToast = () => notify.mock.calls[0]![0] as ToastArg;
|
|
|
|
function qc() {
|
|
return new QueryClient({ defaultOptions: { queries: { retry: false } } });
|
|
}
|
|
|
|
beforeEach(() => {
|
|
downloadLinks.mockReset();
|
|
createDownloadLink.mockReset();
|
|
copyText.mockReset().mockResolvedValue(true);
|
|
notify.mockReset();
|
|
});
|
|
|
|
describe("quickShareLink", () => {
|
|
it("mints a downloadable link on demand, copies it, and toasts with an open-in-new-tab action", async () => {
|
|
downloadLinks.mockResolvedValue([]); // none yet
|
|
createDownloadLink.mockResolvedValue({ id: 7, url: "/watch/tok7" });
|
|
const openSpy = vi.spyOn(window, "open").mockReturnValue(null);
|
|
|
|
const url = await quickShareLink(qc(), { id: 42 }, t);
|
|
|
|
expect(url).toBe(`${origin}/watch/tok7`);
|
|
// Minted with an EMPTY body so the backend default (allow_download=true) applies.
|
|
expect(createDownloadLink).toHaveBeenCalledWith(42, {});
|
|
expect(copyText).toHaveBeenCalledWith(`${origin}/watch/tok7`);
|
|
const arg = firstToast();
|
|
expect(arg.level).toBe("success");
|
|
expect(arg.message).toBe("downloads.share.linkCopied");
|
|
expect(arg.action!.label).toBe("downloads.share.openNewTab");
|
|
arg.action!.onClick();
|
|
expect(openSpy).toHaveBeenCalledWith(`${origin}/watch/tok7`, "_blank", "noopener,noreferrer");
|
|
});
|
|
|
|
it("reuses an existing link instead of minting a duplicate", async () => {
|
|
downloadLinks.mockResolvedValue([{ id: 3, url: "/watch/old" }]);
|
|
|
|
const url = await quickShareLink(qc(), { id: 1 }, t);
|
|
|
|
expect(url).toBe(`${origin}/watch/old`);
|
|
expect(createDownloadLink).not.toHaveBeenCalled();
|
|
expect(firstToast().level).toBe("success");
|
|
});
|
|
|
|
it("still toasts (warning) with the open action when the clipboard copy fails", async () => {
|
|
downloadLinks.mockResolvedValue([{ id: 5, url: "/watch/x" }]);
|
|
copyText.mockResolvedValue(false);
|
|
|
|
const url = await quickShareLink(qc(), { id: 2 }, t);
|
|
|
|
expect(url).toBe(`${origin}/watch/x`); // the link is never a dead end
|
|
const arg = firstToast();
|
|
expect(arg.level).toBe("warning");
|
|
expect(arg.message).toBe("downloads.share.copyFailed");
|
|
expect(arg.action!.label).toBe("downloads.share.openNewTab");
|
|
});
|
|
|
|
it("reports an error and returns null when link creation fails", async () => {
|
|
downloadLinks.mockResolvedValue([]);
|
|
createDownloadLink.mockRejectedValue(new Error("boom"));
|
|
|
|
const url = await quickShareLink(qc(), { id: 9 }, t);
|
|
|
|
expect(url).toBeNull();
|
|
expect(copyText).not.toHaveBeenCalled();
|
|
// Titled with what failed, and carrying why (notifyActionError), not a bare message.
|
|
expect(notify).toHaveBeenCalledWith(
|
|
expect.objectContaining({ level: "error", title: "downloads.share.linkFailed" }),
|
|
);
|
|
});
|
|
});
|