peter
3f047bbad1
Restores CLAUDE.md's canonical transaction rule ("the handler commits; helpers
flush; only quota owns its session") on the config path: sysconfig.set_value /
sysconfig.reset and state.set_sync_paused now flush instead of committing, so a
change lands in ONE transaction with the audit row the route records for it —
previously the helper's internal commit split them, and a crash between left the
mutation persisted with no audit trail.
All callers already commit (the config PATCH/DELETE + audit, the sync pause/resume
+ audit, the scheduler maintenance PATCH); the setup wizard, which relied on the
internal commit, gets an explicit db.commit() after its loop. apply_interval is
deliberately left committing — it performs a live APScheduler reschedule that must
follow the DB persist, so it owns its own unit of work (a legitimate exception,
like the download service transitions). New test locks the flush-not-commit
contract (a rollback before the caller commits discards the change). 368 pass.
90 lines
2.7 KiB
Python
90 lines
2.7 KiB
Python
"""Global admin-controlled app state (e.g. pausing background sync, first-run setup)."""
|
|
import logging
|
|
import secrets
|
|
|
|
from sqlalchemy.orm import Session
|
|
|
|
from app.models import AppState
|
|
from app.security import hash_token
|
|
|
|
log = logging.getLogger("siftlode.state")
|
|
|
|
# Once configuration completes in this process it never reverts, so cache it to skip the per-request
|
|
# DB hit in the setup-mode gate (see main.setup_gate). Starts False; refreshed from the DB.
|
|
_configured_cache = False
|
|
|
|
|
|
def _row(db: Session) -> AppState:
|
|
row = db.get(AppState, 1)
|
|
if row is None:
|
|
row = AppState(id=1, sync_paused=False)
|
|
db.add(row)
|
|
db.commit()
|
|
return row
|
|
|
|
|
|
def is_sync_paused(db: Session) -> bool:
|
|
return _row(db).sync_paused
|
|
|
|
|
|
def set_sync_paused(db: Session, paused: bool) -> None:
|
|
# Flushes, doesn't commit — the caller owns the transaction so the change lands with its audit
|
|
# row in one transaction (B-core-10).
|
|
row = _row(db)
|
|
row.sync_paused = paused
|
|
db.add(row)
|
|
db.flush()
|
|
log.info("Background sync %s", "paused" if paused else "resumed")
|
|
|
|
|
|
# --- First-run install wizard ------------------------------------------------------------
|
|
|
|
def is_configured(db: Session) -> bool:
|
|
return _row(db).configured
|
|
|
|
|
|
def setup_complete() -> bool:
|
|
"""Fast, DB-free check for the request gate: True once configuration finished this process."""
|
|
return _configured_cache
|
|
|
|
|
|
def is_configured_cached(db: Session) -> bool:
|
|
"""Configured check that promotes the module cache once true (configuration is one-way)."""
|
|
global _configured_cache
|
|
if _configured_cache:
|
|
return True
|
|
if is_configured(db):
|
|
_configured_cache = True
|
|
return _configured_cache
|
|
|
|
|
|
def mark_configured(db: Session) -> None:
|
|
"""Finish setup: flip the instance to configured and invalidate the setup token."""
|
|
global _configured_cache
|
|
row = _row(db)
|
|
row.configured = True
|
|
row.setup_token_hash = None
|
|
db.add(row)
|
|
db.commit()
|
|
_configured_cache = True
|
|
log.info("Instance marked configured; setup wizard disabled.")
|
|
|
|
|
|
def rotate_setup_token(db: Session) -> str:
|
|
"""Generate a fresh one-time setup token, persist only its hash, and return the raw token
|
|
(logged at startup so the admin can open the wizard)."""
|
|
raw = secrets.token_urlsafe(24)
|
|
row = _row(db)
|
|
row.setup_token_hash = hash_token(raw)
|
|
db.add(row)
|
|
db.commit()
|
|
return raw
|
|
|
|
|
|
def check_setup_token(db: Session, raw: str | None) -> bool:
|
|
"""Whether `raw` matches the stored setup-token hash (constant-time)."""
|
|
if not raw:
|
|
return False
|
|
stored = _row(db).setup_token_hash
|
|
return stored is not None and secrets.compare_digest(stored, hash_token(raw))
|