peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
56 lines
2.1 KiB
Python
56 lines
2.1 KiB
Python
"""DB-backed test for the data normalization (migration 0060): a JSONB scalar `null` in the
|
|
plex tag columns becomes SQL NULL, while a real array is left untouched. Runs the migration's exact
|
|
UPDATE statements against seeded rows (the migration itself is a no-op in the empty test DB).
|
|
|
|
Uses the DB lane (`db` fixture) — skipped when no Postgres is reachable.
|
|
"""
|
|
|
|
from sqlalchemy import text
|
|
|
|
from app.models import PlexLibrary, PlexShow
|
|
|
|
# Mirror of migration 0060's statements (plex_items runs against an empty table here — proving the
|
|
# SQL is valid for both tables; the assertions below check the seeded plex_shows rows).
|
|
_NORMALIZE = [
|
|
f"UPDATE {t} SET {c} = NULL WHERE jsonb_typeof({c}) = 'null'"
|
|
for t in ("plex_items", "plex_shows")
|
|
for c in ("genres", "directors", "cast_names", "collection_keys")
|
|
]
|
|
|
|
|
|
def test_scalar_null_normalized_array_preserved(db):
|
|
lib = PlexLibrary(plex_key="1", title="Shows", kind="show", enabled=True)
|
|
db.add(lib)
|
|
db.flush()
|
|
db.add_all(
|
|
[
|
|
PlexShow(rating_key="null_row", library_id=lib.id, title="Null genres"),
|
|
PlexShow(rating_key="array_row", library_id=lib.id, title="Real genres"),
|
|
]
|
|
)
|
|
db.commit()
|
|
# Set a pre-0.53.1 JSONB scalar null on one, a genuine array on the other.
|
|
db.execute(text("UPDATE plex_shows SET genres = 'null'::jsonb WHERE rating_key = 'null_row'"))
|
|
db.execute(
|
|
text("""UPDATE plex_shows SET genres = '["Drama"]'::jsonb WHERE rating_key = 'array_row'""")
|
|
)
|
|
db.commit()
|
|
assert (
|
|
db.scalar(text("SELECT jsonb_typeof(genres) FROM plex_shows WHERE rating_key='null_row'"))
|
|
== "null"
|
|
)
|
|
|
|
for stmt in _NORMALIZE:
|
|
db.execute(text(stmt))
|
|
db.commit()
|
|
|
|
# The scalar null is now SQL NULL (jsonb_typeof of SQL NULL is itself NULL, not 'null')...
|
|
assert (
|
|
db.scalar(text("SELECT genres IS NULL FROM plex_shows WHERE rating_key='null_row'")) is True
|
|
)
|
|
# ...and a real array is untouched.
|
|
assert (
|
|
db.scalar(text("SELECT jsonb_typeof(genres) FROM plex_shows WHERE rating_key='array_row'"))
|
|
== "array"
|
|
)
|