The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
120 lines
4.2 KiB
TypeScript
120 lines
4.2 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// `s` puts the caret in the module's search box from anywhere on the page, and Escape hands
|
|
// the keyboard back to the page — the way in needs a way out, or `j`/`k` end up typed into the query.
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import { act, cleanup, render, screen } from "@testing-library/react";
|
|
import SearchBar from "./SearchBar";
|
|
import KeyboardHelp from "./ui/KeyboardHelp";
|
|
import { closeKeyboardHelp, toggleKeyboardHelp } from "../lib/keymap";
|
|
import { pushLayer, removeLayer } from "../lib/layerStack";
|
|
|
|
vi.mock("react-i18next", async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import("react-i18next")>();
|
|
return { ...actual, useTranslation: () => ({ t: (key: string) => key }) };
|
|
});
|
|
|
|
afterEach(() => {
|
|
cleanup();
|
|
closeKeyboardHelp();
|
|
});
|
|
|
|
function press(init: KeyboardEventInit, on?: Element | null): KeyboardEvent {
|
|
const e = new KeyboardEvent("keydown", { bubbles: true, cancelable: true, ...init });
|
|
act(() => {
|
|
(on ?? document.activeElement ?? document.body).dispatchEvent(e);
|
|
});
|
|
return e;
|
|
}
|
|
|
|
const field = () => screen.getByPlaceholderText("Search…") as HTMLInputElement;
|
|
|
|
describe("SearchBar keys", () => {
|
|
it("focuses the box on s, selects the old query, and keeps the s out of it", () => {
|
|
render(<SearchBar value="old query" onChange={() => {}} placeholder="Search…" />);
|
|
const e = press({ key: "s" });
|
|
expect(document.activeElement).toBe(field());
|
|
expect(e.defaultPrevented).toBe(true); // the `s` is not typed into the box it just focused
|
|
expect([field().selectionStart, field().selectionEnd]).toEqual([0, "old query".length]);
|
|
});
|
|
|
|
it("leaves an s typed into another field alone", () => {
|
|
render(
|
|
<>
|
|
<input data-testid="other" />
|
|
<SearchBar value="" onChange={() => {}} placeholder="Search…" />
|
|
</>,
|
|
);
|
|
const other = screen.getByTestId("other");
|
|
act(() => other.focus());
|
|
expect(press({ key: "s" }).defaultPrevented).toBe(false);
|
|
expect(document.activeElement).toBe(other);
|
|
});
|
|
|
|
it("stays quiet under a dialog", () => {
|
|
render(<SearchBar value="" onChange={() => {}} placeholder="Search…" />);
|
|
const id = pushLayer();
|
|
press({ key: "s" });
|
|
removeLayer(id);
|
|
expect(document.activeElement).not.toBe(field());
|
|
});
|
|
|
|
it("gives the keyboard back to the page on Escape", () => {
|
|
render(<SearchBar value="abc" onChange={() => {}} placeholder="Search…" />);
|
|
press({ key: "s" });
|
|
press({ key: "Escape" });
|
|
expect(document.activeElement).toBe(document.body);
|
|
});
|
|
|
|
// Plex's typeahead uses its first Escape to close the result panel; the field keeps focus for that.
|
|
it("lets a caller keep its own Escape", () => {
|
|
render(
|
|
<SearchBar
|
|
value="abc"
|
|
onChange={() => {}}
|
|
placeholder="Search…"
|
|
onKeyDown={(e) => e.key === "Escape" && e.preventDefault()}
|
|
/>,
|
|
);
|
|
press({ key: "s" });
|
|
press({ key: "Escape" });
|
|
expect(document.activeElement).toBe(field());
|
|
});
|
|
|
|
// Through the real hook: the sheet offers `s` only where a search box is mounted.
|
|
it("is listed in the help sheet while a search box is mounted", () => {
|
|
const { unmount } = render(
|
|
<>
|
|
<SearchBar value="" onChange={() => {}} placeholder="Search…" />
|
|
<KeyboardHelp />
|
|
</>,
|
|
);
|
|
act(() => toggleKeyboardHelp());
|
|
expect(screen.getAllByRole("definition").map((d) => d.textContent)).toContain("keys.search");
|
|
unmount();
|
|
closeKeyboardHelp();
|
|
|
|
render(<KeyboardHelp />);
|
|
act(() => toggleKeyboardHelp());
|
|
expect(screen.getAllByRole("definition").map((d) => d.textContent)).not.toContain(
|
|
"keys.search",
|
|
);
|
|
});
|
|
|
|
// Opened over a player, the page keys are quiet — the sheet must not list them there.
|
|
it("is left off a sheet opened over a keyboard-owning layer", () => {
|
|
render(
|
|
<>
|
|
<SearchBar value="" onChange={() => {}} placeholder="Search…" />
|
|
<KeyboardHelp />
|
|
</>,
|
|
);
|
|
const id = pushLayer();
|
|
act(() => toggleKeyboardHelp());
|
|
expect(screen.queryAllByRole("definition").map((d) => d.textContent)).not.toContain(
|
|
"keys.search",
|
|
);
|
|
removeLayer(id);
|
|
});
|
|
});
|