peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
106 lines
3.3 KiB
TypeScript
106 lines
3.3 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// The owner's pick "A": TMDB enriches shows as it does movies — studios, countries, keywords, key
|
|
// crew — and the show page showed none of it, beside a hero whose text stopped at ~55% of the panel. Its
|
|
// hero now has the movie page's second column (facts over crew) and the keywords under the text.
|
|
import { describe, it, expect, afterEach, beforeAll, vi } from "vitest";
|
|
import { render, screen, cleanup, fireEvent } from "@testing-library/react";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
|
|
beforeAll(() => {
|
|
class Stub {
|
|
observe() {}
|
|
unobserve() {}
|
|
disconnect() {}
|
|
takeRecords() {
|
|
return [];
|
|
}
|
|
}
|
|
globalThis.ResizeObserver ??= Stub as unknown as typeof ResizeObserver;
|
|
});
|
|
|
|
vi.mock("react-i18next", async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import("react-i18next")>();
|
|
return {
|
|
...actual,
|
|
useTranslation: () => ({ i18n: { language: "en" }, t: (key: string) => key }),
|
|
};
|
|
});
|
|
|
|
const detail = {
|
|
show: {
|
|
id: "show",
|
|
title: "Fargo",
|
|
summary: "Various chronicles.",
|
|
year: 2014,
|
|
thumb: "",
|
|
art: "",
|
|
content_rating: "TV-MA",
|
|
studio: "26 Keys",
|
|
genres: ["Crime"],
|
|
cast: [],
|
|
status: "new",
|
|
episode_count: 0,
|
|
collection_keys: [],
|
|
tmdb: {
|
|
keywords: ["minnesota", "winter"],
|
|
crew: [{ name: "Noah Hawley", job: "Creator" }],
|
|
studios: ["26 Keys Productions", "MGM Television"],
|
|
production_countries: [{ code: "US", name: "United States" }],
|
|
recommendations: [],
|
|
backdrops: [],
|
|
},
|
|
},
|
|
seasons: [],
|
|
related: [],
|
|
};
|
|
|
|
vi.mock("../lib/api", () => ({
|
|
api: {
|
|
plexShow: () => Promise.resolve(detail),
|
|
updatePrefs: () => Promise.resolve({}),
|
|
},
|
|
EMPTY_PLEX_FILTERS: {},
|
|
plexFilterCount: () => 0,
|
|
}));
|
|
|
|
import { PlexShowView } from "./plexViews";
|
|
|
|
afterEach(cleanup);
|
|
|
|
function renderShow(onFilter = vi.fn(), onOpenPerson = vi.fn()) {
|
|
const qc = new QueryClient({ defaultOptions: { queries: { retry: false } } });
|
|
render(
|
|
<QueryClientProvider client={qc}>
|
|
<PlexShowView
|
|
showId="show"
|
|
onBack={() => {}}
|
|
onPlay={() => {}}
|
|
onOpenSeason={() => {}}
|
|
onOpenShow={() => {}}
|
|
onFilter={onFilter}
|
|
onOpenPerson={onOpenPerson}
|
|
/>
|
|
</QueryClientProvider>,
|
|
);
|
|
return { onFilter, onOpenPerson };
|
|
}
|
|
|
|
describe("the show page's facts, keywords and crew", () => {
|
|
it("shows the facts over the crew beside the text, and the keywords under it", async () => {
|
|
const { onFilter, onOpenPerson } = renderShow();
|
|
const aside = await screen.findByTestId("detail-aside");
|
|
expect(aside.textContent).toContain("MGM Television");
|
|
expect(aside.textContent).toContain("Noah Hawley");
|
|
expect(aside.parentElement!.className).toContain("@5xl:grid-cols-");
|
|
const main = aside.parentElement!.children[0]!;
|
|
expect(main.contains(screen.getByTestId("detail-keywords"))).toBe(true);
|
|
expect(main.contains(screen.getByText("Various chronicles."))).toBe(true);
|
|
// They act as on the movie page: a keyword filters, a crew name opens the person.
|
|
fireEvent.click(screen.getByText("minnesota"));
|
|
expect(onFilter).toHaveBeenCalledWith({ keywords: ["minnesota"] });
|
|
fireEvent.click(screen.getByText("Noah Hawley"));
|
|
expect(onOpenPerson).toHaveBeenCalledWith("Noah Hawley");
|
|
});
|
|
});
|