peter
921c2bf5a4
/code-review high on S3 — 3 low findings, 2 fixed, 1 no-change: - _db_reachable() now probes via a throwaway engine with connect_timeout=3, so a slow/firewalled DATABASE_URL can't hang the whole suite at import (the app engine has no connect timeout). - test_plex_facets sets the "configured" gate flag via monkeypatch (auto-restored) instead of poking state._configured_cache in a manual finally — no leak risk, and the now-unnecessary mark_configured DB write is dropped. No change: test_plex_jsonb_normalize copying migration 0060's SQL is deliberate — migrations must stay self-contained (no app imports) and a shipped migration is immutable, so there's no real drift to guard against. Gate: ruff clean; DB lane 176 passed; pure-logic 172 passed / 4 skipped (fast).
46 lines
2.1 KiB
Python
46 lines
2.1 KiB
Python
"""DB-backed regression for the 0.53.1 hotfix (R6 S3b-test): GET /api/plex/facets?scope=show
|
|
must return 200 — not the "cannot extract elements from a scalar" 500 — for a metadata-poor
|
|
library whose show has a JSONB-scalar `null` genres (a pre-0.53.1 row). The endpoint's
|
|
`jsonb_typeof(genres)='array'` read-guard is what makes it safe; this test would 500 without it.
|
|
|
|
Uses the DB lane (`db` fixture) — skipped when no Postgres is reachable.
|
|
"""
|
|
from fastapi.testclient import TestClient
|
|
from sqlalchemy import text
|
|
|
|
import app.state as state
|
|
from app.auth import current_user
|
|
from app.db import get_db
|
|
from app.main import app
|
|
from app.models import PlexLibrary, PlexShow, User
|
|
|
|
|
|
def test_facets_survives_json_null_genres(db, monkeypatch):
|
|
lib = PlexLibrary(plex_key="1", title="Shows", kind="show", enabled=True)
|
|
db.add(lib)
|
|
db.flush()
|
|
db.add(PlexShow(rating_key="s1", library_id=lib.id, title="No Genre Show"))
|
|
user = User(email="facets@example.com")
|
|
db.add(user)
|
|
db.commit()
|
|
# The request gate 503s an unconfigured instance; flip the process-level "configured" flag the
|
|
# gate reads. monkeypatch auto-restores it, so it can't leak "configured" into another test.
|
|
monkeypatch.setattr(state, "_configured_cache", True)
|
|
# Simulate a pre-0.53.1 row: genres persisted as a JSONB scalar `null` (what SQLAlchemy wrote
|
|
# before none_as_null=True), NOT SQL NULL — this is the value jsonb_array_elements_text() chokes
|
|
# on. A Python None now maps to SQL NULL, so we set the scalar directly.
|
|
db.execute(text("UPDATE plex_shows SET genres = 'null'::jsonb WHERE rating_key = 's1'"))
|
|
db.commit()
|
|
|
|
app.dependency_overrides[get_db] = lambda: db
|
|
app.dependency_overrides[current_user] = lambda: user
|
|
try:
|
|
client = TestClient(app) # no context-manager: skip lifespan (scheduler/HLS sweep)
|
|
resp = client.get("/api/plex/facets?scope=show")
|
|
finally:
|
|
app.dependency_overrides.clear()
|
|
|
|
assert resp.status_code == 200, resp.text
|
|
# The scalar-null show contributes no genres — and, crucially, doesn't abort the whole endpoint.
|
|
assert resp.json()["genres"] == []
|