peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
44 lines
1.7 KiB
Python
44 lines
1.7 KiB
Python
"""The config/state mutators flush but do NOT self-commit, so the caller owns the
|
|
transaction and a change lands together with its audit row. These lock that contract — a rollback
|
|
before the caller commits discards the change (proving no hidden internal commit), while a same-session
|
|
read still sees it (flush visibility). DB lane (`db` fixture) — skipped without Postgres.
|
|
"""
|
|
|
|
from app import state, sysconfig
|
|
|
|
|
|
def test_set_value_flushes_but_leaves_the_commit_to_the_caller(db):
|
|
default = sysconfig.get_int(db, "quota_daily_budget")
|
|
new = default + 4321
|
|
|
|
sysconfig.set_value(db, "quota_daily_budget", new)
|
|
assert sysconfig.get_int(db, "quota_daily_budget") == new # visible in-session (flushed)
|
|
|
|
db.rollback() # the caller never committed
|
|
assert (
|
|
sysconfig.get_int(db, "quota_daily_budget") == default
|
|
) # discarded — no hidden self-commit
|
|
|
|
|
|
def test_reset_flushes_but_leaves_the_commit_to_the_caller(db):
|
|
default = sysconfig.get_int(db, "quota_daily_budget")
|
|
sysconfig.set_value(db, "quota_daily_budget", default + 10)
|
|
db.commit() # a persisted override to reset
|
|
|
|
sysconfig.reset(db, "quota_daily_budget")
|
|
assert sysconfig.get_int(db, "quota_daily_budget") == default # reset visible in-session
|
|
db.rollback()
|
|
assert (
|
|
sysconfig.get_int(db, "quota_daily_budget") == default + 10
|
|
) # reset discarded until committed
|
|
|
|
|
|
def test_set_sync_paused_flushes_but_leaves_the_commit_to_the_caller(db):
|
|
assert state.is_sync_paused(db) is False
|
|
|
|
state.set_sync_paused(db, True)
|
|
assert state.is_sync_paused(db) is True # visible in-session
|
|
|
|
db.rollback()
|
|
assert state.is_sync_paused(db) is False # discarded — the caller owns the commit
|