peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
71 lines
3.7 KiB
TypeScript
71 lines
3.7 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { compileReport, shippedSources, type CompileReport } from "./compilerSkips.testkit";
|
|
|
|
// The React Compiler bails out of a component it cannot prove safe WITHOUT a word: the component
|
|
// still works, it just re-renders everything under it on every render. The channel manager is where
|
|
// it hurt (the owner, 2026-10-03): Channels and DataTable both bailed out, every open, close and
|
|
// reposition of a row's right-click menu rebuilt the rows and columns, and on "All" rows the menu
|
|
// took ~0.9 s to open and ~0.6 s to close. An audit then found 95 such functions across src.
|
|
//
|
|
// A RATCHET over everything the build compiles. KNOWN_SKIPS is the exact set the compiler
|
|
// skips today, `file → function → the compiler's category`; everything else must compile. Both
|
|
// directions are red:
|
|
// • a NEW skip (or a known one changing category) — fix the function; if it truly cannot be
|
|
// compiled, adding it here is a decision for the owner, with the reason in docs/gates.md;
|
|
// • a skip that is GONE — delete its entry, so the list only ever shrinks.
|
|
// A cleanup burned it down from 93 to the one function below: it read the popover engine through
|
|
// destructuring, moved every render-phase ref write to `useEffectEvent` / `useLatest`, took
|
|
// try/finally and every conditional, loop or optional call out of try blocks (the compiler cannot
|
|
// lower them yet — and `react-hooks/todo` does not see the latter, so THIS test is what catches them)
|
|
// and replaced the two exhaustive-deps suppressions, each of which skipped its whole function.
|
|
// VirtualGrid stays: TanStack Virtual's API cannot be memoized safely (IncompatibleLibrary).
|
|
const KNOWN_SKIPS: CompileReport["skipped"] = {
|
|
"components/ui/VirtualGrid.tsx": { VirtualGrid: "IncompatibleLibrary" },
|
|
};
|
|
|
|
// The files a regression hurt most: compiled, and they must stay so (a positive check too, so a
|
|
// harness that compiled nothing could not pass as "no skips").
|
|
const MUST_COMPILE: Record<string, string[]> = {
|
|
"components/Channels.tsx": ["Channels"],
|
|
"components/ui/DataTable.tsx": ["DataTable"],
|
|
// Under every button and every popover in the app.
|
|
"components/ui/FocusSafeButton.tsx": ["FocusSafeButton"],
|
|
"components/ui/anchoredPopoverHooks.ts": ["useAnchoredPopover"],
|
|
"components/ui/AnchoredPopover.tsx": ["PopoverSurfaceInner"],
|
|
// The two players — the largest components here, and the last to compile.
|
|
"components/PlexPlayer.tsx": ["PlexPlayer"],
|
|
"components/PlayerModal.tsx": ["PlayerModal"],
|
|
"lib/playerModalHooks.ts": ["useYtProgress"],
|
|
};
|
|
|
|
type Row = [file: string, fn: string, category: string];
|
|
const rows = (skips: CompileReport["skipped"]): Row[] =>
|
|
Object.entries(skips).flatMap(([file, fns]) =>
|
|
Object.entries(fns).map(([fn, category]): Row => [file, fn, category]),
|
|
);
|
|
|
|
describe("the React Compiler", () => {
|
|
// ~8 s for the whole tree, once, shared by the checks below.
|
|
const report = compileReport(shippedSources());
|
|
const actual = rows(report.skipped);
|
|
const known = rows(KNOWN_SKIPS);
|
|
const key = ([f, fn]: Row) => `${f} → ${fn}`;
|
|
|
|
it("skips nothing new (fix it, or the owner decides to list it)", () => {
|
|
const knownAs = new Map(known.map((r) => [key(r), r[2]]));
|
|
expect(
|
|
actual.filter((r) => knownAs.get(key(r)) !== r[2]).map((r) => `${key(r)}: ${r[2]}`),
|
|
).toEqual([]);
|
|
});
|
|
|
|
it("lists no skip that has gone (delete it — the list only shrinks)", () => {
|
|
const actualAs = new Map(actual.map((r) => [key(r), r[2]]));
|
|
expect(known.filter((r) => !actualAs.has(key(r))).map(key)).toEqual([]);
|
|
});
|
|
|
|
it.each(Object.entries(MUST_COMPILE))("compiles %s", (file, fns) => {
|
|
expect(report.skipped[file] ?? {}).toEqual({});
|
|
for (const fn of fns) expect(report.compiled[file]).toContain(fn);
|
|
});
|
|
});
|