Files
siftlode/frontend/src/components/downloadAdmin.dom.test.tsx
T
peter 4aaaaa7860 chore(comments): drop epic, sprint and review-round ids from the code
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").

Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.

Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).

One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
2026-10-05 00:19:39 +02:00

91 lines
3.9 KiB
TypeScript

// @vitest-environment jsdom
//
// The admin's download-quota editor rendered NOTHING while its quota loaded and nothing when
// the load failed, so the click looked dead. It now opens at once and says which it is. The save
// turns the GB field back into bytes; the reset drops the override.
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { cleanup, fireEvent, render, screen, waitFor } from "@testing-library/react";
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
import type { ReactNode } from "react";
import { api } from "../lib/api";
import { QuotaModal } from "./downloadAdmin";
vi.mock("react-i18next", async (importOriginal) => {
const actual = await importOriginal<typeof import("react-i18next")>();
return {
...actual,
useTranslation: () => ({ t: (key: string) => key, i18n: { language: "en" } }),
};
});
const GiB = 1024 ** 3;
const QUOTA = { max_bytes: 5 * GiB, max_jobs: 10, max_concurrent: 2, unlimited: false };
let qc: QueryClient;
const wrap = (ui: ReactNode) => <QueryClientProvider client={qc}>{ui}</QueryClientProvider>;
const open = (onClose = () => {}) =>
render(wrap(<QuotaModal userId={4} email="a@b.c" onClose={onClose} />));
beforeEach(() => {
qc = new QueryClient({ defaultOptions: { queries: { retry: false } } });
});
afterEach(() => {
cleanup();
vi.restoreAllMocks();
});
describe("the download-quota editor", () => {
it("opens at once and says it is loading", () => {
vi.spyOn(api, "adminGetDownloadQuota").mockReturnValue(new Promise(() => {}) as never);
open();
expect(screen.getByText("downloads.admin.quotaTitle")).toBeTruthy();
expect(screen.getAllByRole("status").length).toBeGreaterThan(0);
});
it("says a failed load failed, and retries it", async () => {
const get = vi
.spyOn(api, "adminGetDownloadQuota")
.mockRejectedValueOnce(new Error("down"))
.mockResolvedValueOnce(QUOTA as never);
open();
expect((await screen.findByRole("alert")).textContent).toContain("common.loadError");
fireEvent.click(screen.getByText("common.retry"));
await screen.findByDisplayValue("5");
expect(get).toHaveBeenCalledTimes(2);
});
it("gives the first field the focus when the form arrives after a retry", async () => {
// jsdom lays nothing out, so every element reads as hidden to the dialog's focus rules.
vi.spyOn(HTMLElement.prototype, "offsetParent", "get").mockReturnValue(document.body);
vi.spyOn(api, "adminGetDownloadQuota")
.mockRejectedValueOnce(new Error("down"))
.mockResolvedValueOnce(QUOTA as never);
open();
await screen.findByRole("alert");
const retry = screen.getByText("common.retry").closest("button")!;
await waitFor(() => expect(document.activeElement).toBe(retry));
fireEvent.click(retry); // the Retry gives way to the spinner: its focus must not fall to <body>
const first = await screen.findByDisplayValue("5");
await waitFor(() => expect(document.activeElement).toBe(first));
});
it("saves the GB field as bytes, and the reset drops the override", async () => {
vi.spyOn(api, "adminGetDownloadQuota").mockResolvedValue(QUOTA as never);
const set = vi.spyOn(api, "adminSetDownloadQuota").mockResolvedValue(QUOTA as never);
const reset = vi.spyOn(api, "adminResetDownloadQuota").mockResolvedValue(QUOTA as never);
const onClose = vi.fn();
open(onClose);
fireEvent.change(await screen.findByDisplayValue("5"), { target: { value: "1.5" } });
fireEvent.click(screen.getByText("downloads.admin.save"));
await waitFor(() => expect(onClose).toHaveBeenCalledTimes(1));
expect(set).toHaveBeenCalledWith(4, {
max_bytes: Math.round(1.5 * GiB),
max_jobs: 10,
max_concurrent: 2,
unlimited: false,
});
fireEvent.click(screen.getByText("downloads.admin.reset"));
await waitFor(() => expect(reset).toHaveBeenCalledWith(4));
});
});