peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
38 lines
1.7 KiB
TypeScript
38 lines
1.7 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// A Plex query follows a language switch. `plexLang()` read the i18n singleton, and under the
|
|
// React Compiler a value with no reactive input is computed once: after switching to Hungarian the
|
|
// comfort shelf kept asking for its English cards. The language now comes off useTranslation. Real
|
|
// i18n (the key-echo mock does not re-render on a switch, which is the very thing under test).
|
|
import { describe, it, expect, afterEach, vi } from "vitest";
|
|
import type { ReactNode } from "react";
|
|
import { renderHook, act, waitFor, cleanup } from "@testing-library/react";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import { setLanguage } from "../i18n";
|
|
import { api } from "../lib/api";
|
|
import { useComfortPin } from "./comfortPin";
|
|
|
|
// Unmount BEFORE the language goes back: a mounted reader re-renders on the switch, and under a loaded
|
|
// run that render landed after the test environment was gone ("window is not defined").
|
|
afterEach(() => {
|
|
cleanup();
|
|
vi.restoreAllMocks();
|
|
setLanguage("en");
|
|
});
|
|
|
|
function wrapper({ children }: { children: ReactNode }) {
|
|
const qc = new QueryClient({ defaultOptions: { queries: { retry: false } } });
|
|
return <QueryClientProvider client={qc}>{children}</QueryClientProvider>;
|
|
}
|
|
|
|
describe("the comfort shelf after a language switch", () => {
|
|
it("asks for its cards in the new language", async () => {
|
|
const get = vi.spyOn(api, "comfortPins").mockImplementation(() => new Promise(() => {}));
|
|
setLanguage("en");
|
|
renderHook(() => useComfortPin(true), { wrapper });
|
|
await waitFor(() => expect(get).toHaveBeenCalledWith("en"));
|
|
act(() => setLanguage("hu"));
|
|
await waitFor(() => expect(get).toHaveBeenCalledWith("hu"));
|
|
});
|
|
});
|