peter
8a50538275
`req` opens its blocking dialog for 400/409/422/5xx only. A 403/404/429 was left to the caller and a 502-504 or lost connection got just the self-clearing connection notice, so 34 mutations without a reporting onError and 15 direct api writes with a bare or missing catch failed in silence: a hidden channel that snapped back, a share link that never revoked, a confirmed account delete that ended with nothing said. - lib/queryClient: one MutationCache reporter. react-query awaits it BEFORE the mutation's own onError, so it waits a task and skips a failure the site already reported; the toast title comes from `meta.failTitle`, `meta.errorShownInline` opts out. - notifyActionError: title names WHAT failed, the line under it says WHY (`failureReason`: a structured localized detail, else the status). It marks the error reported (`markReported`), so nothing reports one failure twice; `notifyKnownFailure` for a site's own specific sentence. - Every silent site named (45 new HU/EN titles, 4 reasons). Stale "the global dialog shows it" comments corrected on the job actions, channel block, Plex sync, cookies, download enqueue, account delete and usePref. - Channels passed the tag hook's channel id to the reporter as the error; the tag and priority hooks now report themselves, with the real error. - A contract test keeps every useMutation naming its failure; CLAUDE.md gains the pattern row. - history.dom.test: the "navigates only once the entries are back" assertion raced an async act's macrotask flush (1 in 5 runs); it now asserts from a later popstate listener.
33 lines
1.3 KiB
TypeScript
33 lines
1.3 KiB
TypeScript
import { HttpError } from "./api";
|
|
import { markReported } from "./api/core";
|
|
import { notify } from "./notifications";
|
|
import { notifyActionError } from "./actionErrors";
|
|
import i18n from "../i18n";
|
|
|
|
// A YouTube-gated action (subscribe, sync, backfill, unsubscribe) that 403s means the user hasn't
|
|
// granted the write scope — surface a "Connect" affordance instead of a vague failure. Pass
|
|
// `onConnect` to offer the connect-wizard button (callers that have no wizard handle, e.g. the
|
|
// channel page, just get the message). `fallbackMessage` is the already-translated non-403 error.
|
|
export function notifyYouTubeActionError(
|
|
err: unknown,
|
|
fallbackMessage: string,
|
|
onConnect?: () => void,
|
|
): void {
|
|
const httpErr = err instanceof HttpError ? err : null;
|
|
if (httpErr?.status === 403) {
|
|
// A 403 on a YouTube write action means the write scope isn't granted — offer to connect.
|
|
notify({
|
|
level: "error",
|
|
message: i18n.t("channels.notify.needYouTube"),
|
|
action: onConnect
|
|
? { label: i18n.t("channels.notify.connect"), onClick: onConnect }
|
|
: undefined,
|
|
});
|
|
markReported(err);
|
|
return;
|
|
}
|
|
// Any other error: prefer the server's own reason (e.g. "Not enough quota left today") over the
|
|
// caller's generic fallback — the useful detail was being discarded (U-3.2.8).
|
|
notifyActionError(err, fallbackMessage);
|
|
}
|