peter
351eb5fd13
/code-review high on S2 — 4 findings, 2 fixed, 2 no-change: - test_plex_sync_txn: a faked PlexClient fails on the second library; asserts the first library's row survives (per-section commit). Mutation-checked — moving the commit back out of the loop turns it red ([] == ['1']). - dropped the `[[quota-owns-its-session]]` memory slugs from quota.py docstrings (a dangling private-note reference in shipped code; the reasoning is already inline). No change: record_usage's per-call second connection is a transient spike, fine for this app's concurrency; the two-site `with SessionLocal()` duplication isn't worth a helper until a third caller appears. Gate: ruff clean; DB lane 181 green.
45 lines
1.7 KiB
Python
45 lines
1.7 KiB
Python
"""DB-backed test for R6 S2's Plex per-section commit: a PlexError on a LATER library must keep the
|
|
libraries already mirrored (committed per section), not roll the whole reconcile back. Uses the DB
|
|
lane (`db` fixture) with a faked PlexClient — skipped without Postgres.
|
|
"""
|
|
from sqlalchemy import select
|
|
|
|
from app.plex import sync
|
|
from app.plex.client import PlexError
|
|
from app.models import PlexLibrary
|
|
|
|
|
|
class _FakePlex:
|
|
def __enter__(self):
|
|
return self
|
|
|
|
def __exit__(self, *exc):
|
|
return False # don't suppress the PlexError
|
|
|
|
def sections(self):
|
|
return [
|
|
{"type": "movie", "key": "1", "title": "Lib One"},
|
|
{"type": "movie", "key": "2", "title": "Lib Two"},
|
|
]
|
|
|
|
|
|
def test_late_section_failure_keeps_earlier_sections(db, monkeypatch):
|
|
monkeypatch.setattr(sync.sysconfig, "get_bool", lambda *a, **k: True) # plex_enabled
|
|
monkeypatch.setattr(sync, "_enabled_section_keys", lambda db: None) # all sections wanted
|
|
monkeypatch.setattr(sync, "PlexClient", lambda db: _FakePlex())
|
|
monkeypatch.setattr(sync, "_sync_movies", lambda *a, **k: None) # skip the real Plex fetch
|
|
|
|
# Section 1 completes and commits; section 2's collections step raises → its work rolls back.
|
|
def collections(db, plex, lib, stats):
|
|
if lib.plex_key == "2":
|
|
raise PlexError("boom on the second library")
|
|
|
|
monkeypatch.setattr(sync, "_sync_collections", collections)
|
|
|
|
result = sync.sync(db)
|
|
|
|
assert "error" in result # the run reports the failure honestly
|
|
# Section 1's library survived the section-2 failure (per-section commit); section 2 rolled back.
|
|
keys = db.scalars(select(PlexLibrary.plex_key).order_by(PlexLibrary.plex_key)).all()
|
|
assert keys == ["1"]
|