peter
4aaaaa7860
The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
40 lines
1.5 KiB
Python
40 lines
1.5 KiB
Python
"""The admin Configuration page reads every override in one query.
|
|
|
|
`sysconfig.describe()` did a `db.get` per key to tell whether an override was set, and `get()` did one
|
|
more for its value: ~55 keys, and two round trips for a key with no row, since the session cannot cache
|
|
an absence. That was ~40 ms of the page's ~55 on prod. It now reads the table once. DB lane.
|
|
"""
|
|
|
|
from sqlalchemy import event
|
|
|
|
from app import sysconfig
|
|
|
|
|
|
def _statements(db, fn) -> int:
|
|
seen: list[str] = []
|
|
engine = db.get_bind()
|
|
listener = lambda *a, **k: seen.append(a[2]) # noqa: E731 — (conn, cursor, statement, …)
|
|
event.listen(engine, "before_cursor_execute", listener)
|
|
try:
|
|
fn()
|
|
finally:
|
|
event.remove(engine, "before_cursor_execute", listener)
|
|
return len(seen)
|
|
|
|
|
|
def test_describe_reads_the_overrides_once(db):
|
|
sysconfig.set_value(db, "quota_daily_budget", 5000)
|
|
db.commit()
|
|
assert _statements(db, lambda: sysconfig.describe(db)) == 1
|
|
|
|
|
|
def test_describe_shows_the_stored_value_and_the_default(db):
|
|
sysconfig.set_value(db, "quota_daily_budget", 5000)
|
|
db.commit()
|
|
items = {i["key"]: i for g in sysconfig.describe(db)["groups"].values() for i in g}
|
|
assert items["quota_daily_budget"]["is_set"] is True
|
|
assert items["quota_daily_budget"]["value"] == 5000
|
|
other = next(i for k, i in items.items() if k != "quota_daily_budget" and not i["secret"])
|
|
assert other["is_set"] is False
|
|
assert other["value"] == other["default"]
|