The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
144 lines
5.3 KiB
TypeScript
144 lines
5.3 KiB
TypeScript
import { forwardRef } from "react";
|
||
import type { ButtonHTMLAttributes, ReactNode } from "react";
|
||
import clsx from "clsx";
|
||
import { X } from "lucide-react";
|
||
import { FocusSafeButton } from "./FocusSafeButton";
|
||
import { handOffFocus } from "../../lib/useFocusKeeper";
|
||
import { chipClass, type ChipSize, type ChipVariant } from "./chipStyles";
|
||
|
||
// The chip family (docs/DESIGN.md "One primitive per button family"): a small rounded-full token that
|
||
// is a filter, an applied narrowing, a tag, or a suggestion. It was hand-painted in five files with
|
||
// five geometries; this is the one. `FilterChipGroup` renders a single-select row of these.
|
||
//
|
||
// filter — a selectable option (a year, a tag filter, a content type). Toggles with `pressed`: the
|
||
// `.pill` recipe in index.css paints the solid accent when on. Also the "+N" overflow and
|
||
// "More…" triggers, which light up while their popover is open (aria-expanded).
|
||
// token — an applied narrowing, tinted accent (the `.chip` recipe): it exists because it is on.
|
||
// tag — a user's tag, the solid accent (`.chip-solid`). Dense: it sits in table rows.
|
||
// suggest — dashed accent: a suggestion not yet taken.
|
||
// ghost — dashed neutral: the "add a tag" trigger, quiet in every table row until reached for.
|
||
//
|
||
// Nothing goes under 24px (B1, WCAG 2.5.8) and a coarse pointer grows every chip to 44 (A3).
|
||
|
||
type ChipProps = ButtonHTMLAttributes<HTMLButtonElement> & {
|
||
variant?: ChipVariant;
|
||
size?: ChipSize;
|
||
/** A filter chip that toggles: aria-pressed, painted solid when on. */
|
||
pressed?: boolean;
|
||
/** Leading glyph (a lucide element). */
|
||
icon?: ReactNode;
|
||
/** The whole chip removes what it stands for: a trailing × and the removal as its name. A press
|
||
* that holds the focus hands it to the chip's neighbour before the removal, not to <body>. */
|
||
removeLabel?: string;
|
||
};
|
||
|
||
/** A chip that is itself the control (a toggle, a removal, an accept, a "+N" trigger). */
|
||
export const Chip = forwardRef<HTMLButtonElement, ChipProps>(function Chip(
|
||
{
|
||
variant = "filter",
|
||
size = "sm",
|
||
pressed,
|
||
icon,
|
||
removeLabel,
|
||
type,
|
||
className,
|
||
children,
|
||
onClick,
|
||
...rest
|
||
},
|
||
ref,
|
||
) {
|
||
return (
|
||
<FocusSafeButton
|
||
ref={ref}
|
||
type={type ?? "button"}
|
||
aria-pressed={pressed}
|
||
aria-label={removeLabel}
|
||
title={removeLabel}
|
||
className={clsx(chipClass(variant, size), removeLabel && "pr-1.5", className)}
|
||
onClick={(e) => {
|
||
// A removal chip unmounts with what it removes: from the keyboard it holds the focus, which
|
||
// went to <body> (the active-filter chips of the feed and Plex). Every
|
||
// removal chip gets it here, once, instead of each caller remembering.
|
||
if (removeLabel && e.currentTarget === document.activeElement)
|
||
handOffFocus(e.currentTarget, () => onClick?.(e));
|
||
else onClick?.(e);
|
||
}}
|
||
{...rest}
|
||
>
|
||
{icon}
|
||
{children}
|
||
{removeLabel && <X className="size-3" aria-hidden="true" />}
|
||
</FocusSafeButton>
|
||
);
|
||
});
|
||
|
||
/** A chip whose label is not the control but which carries its own trailing × (a captured filter in
|
||
* a saved view, a suggestion with a dismiss). Two sibling controls at most, never a button in a
|
||
* button: `onClick` makes the body one (an accept), `onDismiss` the ×. */
|
||
export function DismissibleChip({
|
||
variant = "token",
|
||
size = "sm",
|
||
icon,
|
||
children,
|
||
onClick,
|
||
bodyLabel,
|
||
bodyTitle,
|
||
onDismiss,
|
||
dismissLabel,
|
||
className,
|
||
}: {
|
||
variant?: Exclude<ChipVariant, "filter">;
|
||
size?: ChipSize;
|
||
icon?: ReactNode;
|
||
children: ReactNode;
|
||
onClick?: () => void;
|
||
bodyLabel?: string;
|
||
bodyTitle?: string;
|
||
onDismiss: () => void;
|
||
dismissLabel: string;
|
||
className?: string;
|
||
}) {
|
||
const body = (
|
||
<>
|
||
{icon}
|
||
<span className="truncate">{children}</span>
|
||
</>
|
||
);
|
||
return (
|
||
<span className={clsx(chipClass(variant, size), "pr-0.5 min-w-0", className)}>
|
||
{onClick ? (
|
||
<FocusSafeButton
|
||
type="button"
|
||
onClick={onClick}
|
||
aria-label={bodyLabel}
|
||
title={bodyTitle}
|
||
// -my-px + stretch: the body reaches over the chip's 1px edges to the chip's full 24 (44 on
|
||
// touch), as the × does; stretched inside the edges it was 22, under the B1 floor.
|
||
className="-my-px inline-flex min-w-0 items-center gap-1 self-stretch [&>svg]:size-3 [&>svg]:shrink-0"
|
||
>
|
||
{body}
|
||
</FocusSafeButton>
|
||
) : (
|
||
<span className="inline-flex min-w-0 items-center gap-1 [&>svg]:size-3">{body}</span>
|
||
)}
|
||
<FocusSafeButton
|
||
type="button"
|
||
onClick={(e) => {
|
||
// From the keyboard the × holds the focus, and the chip unmounts: hand the focus to the
|
||
// next chip (else the previous one, else what follows the row) first, not to <body>.
|
||
// A mouse press on it leaves the focus where it was.
|
||
const chip = e.currentTarget.parentElement;
|
||
if (chip && e.currentTarget === document.activeElement) handOffFocus(chip, onDismiss);
|
||
else onDismiss();
|
||
}}
|
||
aria-label={dismissLabel}
|
||
title={dismissLabel}
|
||
className="-my-px grid size-6 shrink-0 place-items-center rounded-full transition state-layer touch-target"
|
||
>
|
||
<X className="size-3" aria-hidden="true" />
|
||
</FocusSafeButton>
|
||
</span>
|
||
);
|
||
}
|