The code cited its plan instead of saying why: `E28 review J4`, `(R6 S3b)`, `S1 justified…`,
`deep-review round 5`. That plan lives in the private ops repo, so for every reader of this one the
citation was noise, and a sentence whose subject was the plan step ("round 2 showed…") hid its
lesson behind an id. Each one is gone and the "why" kept: a bare citation is deleted, a sentence
carrying a lesson is reworded around it ("a later attempt showed…").
Measured (`scripts/audit_metrics.py`, product code): 652 lines in 270 files carried an epic code by
the definition the next commit holds (507 / 241 by the old, two-digit-only one) -> 0. Across all
code, tests, scripts and configs: ~1100 epic-code lines plus ~320 sprint/round ids.
Behaviour unchanged, checked mechanically: every changed .py file has the same AST once docstrings
are blanked; css/sh/toml/yml/json files are identical once comments are stripped; the only
non-comment changes in TS/JS are test titles, one description string in a contract table, and five
ESLint messages, whose text is all the gates snapshot diff holds. Not touched: Markdown (docs and
the changelog keep their history), Alembic migrations, TV episode notation (`S2 · E5`), DESIGN.md
ids (`C1`, `B4`, `S3h`), tracker ids (`SEC-16`, `DX-17`).
One stale claim fixed on the way: test_hls_reaper's docstring said the player checkpoints "every
10 s whether or not it is playing", which plex/stream.py calls wrong; it now says what the code does.
100 lines
3.7 KiB
TypeScript
100 lines
3.7 KiB
TypeScript
// @vitest-environment jsdom
|
|
//
|
|
// docs/DESIGN.md "Text stays selectable": a button whose text is a title or a name is `selectable` —
|
|
// its text selects (Chrome selects none inside a button without `user-select: text`), and the click
|
|
// that ends selecting it, or a press dragged past the slop, does nothing. Held here, on the primitive every button family is built on.
|
|
import { describe, it, expect, vi, afterEach } from "vitest";
|
|
import { render, screen, cleanup, fireEvent } from "@testing-library/react";
|
|
import { Pressable } from "./Pressable";
|
|
import { Button } from "./Button";
|
|
|
|
afterEach(() => {
|
|
window.getSelection()!.removeAllRanges();
|
|
cleanup();
|
|
});
|
|
|
|
function selectText(el: Element) {
|
|
const range = document.createRange();
|
|
range.selectNodeContents(el);
|
|
window.getSelection()!.removeAllRanges();
|
|
window.getSelection()!.addRange(range);
|
|
}
|
|
|
|
describe("a selectable button", () => {
|
|
it("lets its text select, and ignores the click that ends a selection", () => {
|
|
const onClick = vi.fn();
|
|
render(
|
|
<Pressable selectable onClick={onClick}>
|
|
<span>Andor</span>
|
|
</Pressable>,
|
|
);
|
|
const btn = screen.getByRole("button");
|
|
expect(btn.classList.contains("select-text")).toBe(true);
|
|
selectText(screen.getByText("Andor"));
|
|
fireEvent.click(btn, { detail: 1 }); // the mouseup that ended the drag-select
|
|
expect(onClick).not.toHaveBeenCalled();
|
|
window.getSelection()!.removeAllRanges();
|
|
fireEvent.click(btn, { detail: 1 });
|
|
expect(onClick).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
// Enter / Space on a focused title with its words still selected (selected, then
|
|
// tabbed to) did nothing — a keyboard click ends no selection; it carries no pointer at all.
|
|
it("a keyboard click opens even with the title's words selected", () => {
|
|
const onClick = vi.fn();
|
|
render(
|
|
<Pressable selectable onClick={onClick}>
|
|
<span>Andor</span>
|
|
</Pressable>,
|
|
);
|
|
selectText(screen.getByText("Andor"));
|
|
fireEvent.click(screen.getByRole("button"), { detail: 0 });
|
|
expect(onClick).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("ignores a press dragged past the slop, keeps a steady one and a keyboard click", () => {
|
|
const onClick = vi.fn();
|
|
render(
|
|
<Pressable selectable onClick={onClick}>
|
|
Andor
|
|
</Pressable>,
|
|
);
|
|
const btn = screen.getByRole("button");
|
|
fireEvent.mouseDown(btn, { clientX: 10, clientY: 10 });
|
|
fireEvent.click(btn, { detail: 1, clientX: 40, clientY: 10 });
|
|
expect(onClick).not.toHaveBeenCalled();
|
|
fireEvent.mouseDown(btn, { clientX: 10, clientY: 10 });
|
|
fireEvent.click(btn, { detail: 1, clientX: 13, clientY: 12 });
|
|
expect(onClick).toHaveBeenCalledTimes(1);
|
|
// Enter / Space: a click with no pointer, wherever the last press was.
|
|
fireEvent.mouseDown(btn, { clientX: 10, clientY: 10 });
|
|
fireEvent.click(btn, { detail: 0, clientX: 0, clientY: 0 });
|
|
expect(onClick).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
it("still clicks when the selection is somewhere else on the page", () => {
|
|
const onClick = vi.fn();
|
|
render(
|
|
<>
|
|
<p>elsewhere</p>
|
|
<Button variant="link-muted" selectable onClick={onClick}>
|
|
Andor
|
|
</Button>
|
|
</>,
|
|
);
|
|
selectText(screen.getByText("elsewhere"));
|
|
screen.getByRole("button").click();
|
|
expect(onClick).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("is off unless asked: a plain button neither selects nor guards", () => {
|
|
const onClick = vi.fn();
|
|
render(<Pressable onClick={onClick}>Save</Pressable>);
|
|
const btn = screen.getByRole("button");
|
|
expect(btn.classList.contains("select-text")).toBe(false);
|
|
selectText(btn);
|
|
btn.click();
|
|
expect(onClick).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|